Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tracker: Unchecked return values

Browse Source 
Check that find_directory() and path.Append() succeeded.
This commit is contained in:
John Scipione 2014-07-24 22:56:45 -04:00
parent 38f3b29c70
commit e5355e2814
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/kits/tracker/FindPanel.cpp
View File

@ -3252,11 +3252,11 @@ MostUsedNames::~MostUsedNames()
// write most used list to file
BPath path;
if (find_directory(B_USER_SETTINGS_DIRECTORY, &path, true) != B_OK)
if (find_directory(B_USER_SETTINGS_DIRECTORY, &path, true) != B_OK
|| path.Append(fDirectory) != B_OK || path.Append(fFileName) != B_OK) {
return;
}
path.Append(fDirectory);
path.Append(fFileName);
BFile file(path.Path(), B_WRITE_ONLY | B_CREATE_FILE | B_ERASE_FILE);
if (file.InitCheck() == B_OK) {
for (int32 i = 0; i < fList.CountItems(); i++) {
@ -3393,11 +3393,10 @@ MostUsedNames::LoadList()
// load the most used names list
BPath path;
if (find_directory(B_USER_SETTINGS_DIRECTORY, &path, true) != B_OK)
if (find_directory(B_USER_SETTINGS_DIRECTORY, &path, true) != B_OK
|| path.Append(fDirectory) != B_OK || path.Append(fFileName) != B_OK) {
return;
path.Append(fDirectory);
path.Append(fFileName);
}
FILE* file = fopen(path.Path(), "r");
if (file == NULL)