Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BMessage: Fix declared variable-length array has negative size

Browse Source 
Add checks for value of 'size', since FlattenedSize() may return
negative value (B_NO_INIT).
Pointed out by Clang Static Analyzer.

Change-Id: I68176ee47076512a0b96539f9986ac5edbb587af
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3772
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
This commit is contained in:
Murai Takashi 2021-03-12 20:08:23 +09:00 committed by Jérôme Duval
parent 06a78d0d88
commit e459857d1c
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/kits/app/Message.cpp
View File

@ -3241,6 +3241,9 @@ BMessage::ReplaceMessage(const char* name, int32 index, const BMessage* message)
return B_BAD_VALUE;
ssize_t size = message->FlattenedSize();
if (size < 0)
return B_BAD_VALUE;
char buffer[size];
status_t error = message->Flatten(buffer, size);
@ -3266,6 +3269,9 @@ BMessage::ReplaceFlat(const char* name, int32 index, BFlattenable* object)
return B_BAD_VALUE;
ssize_t size = object->FlattenedSize();
if (size < 0)
return B_BAD_VALUE;
char buffer[size];
status_t error = object->Flatten(buffer, size);