Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel_extreme: filter out some video modes

Browse Source 
Only in the specific case of:
- Generation 2 or 3 hardware (with a limited panel fitter)
- No EDID is found (so we have no idea about timing limits)
- A VBT is found (so we know the native resolution of the LCD panel)

Only in this case, restrict available resolutions to the ones not larger
than the VBT mode. Larger resolutions don't work and result in a black
screen.

In all other cases, we should normally figure out appropriate
resolutions from the EDID limits and our well-known modes list.

Change-Id: I3bba9f53b92c4c647e0d644fa0181f6fe96d1fc4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2235
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
This commit is contained in:
Adrien Destugues 2020-02-09 18:44:40 +01:00 committed by waddlesplash
parent 6758018a21
commit dd0e8e49f3
1 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/add-ons/accelerants/intel_extreme/mode.cpp
View File

@ -145,6 +145,21 @@ set_frame_buffer_base()
}
static bool
limit_modes_for_gen3_lvds(display_mode* mode)
{
// Filter out modes with resolution higher than the internal LCD can
// display.
// FIXME do this only for that display. The whole display mode logic
// needs to be adjusted to know which display we're talking about.
if (gInfo->shared_info->panel_mode.virtual_width < mode->virtual_width)
return false;
if (gInfo->shared_info->panel_mode.virtual_height < mode->virtual_height)
return false;
return true;
}
/*! Creates the initial mode list of the primary accelerant.
It's called from intel_init_accelerant().
*/
@ -184,10 +199,14 @@ create_mode_list(void)
// We could not read any EDID info. Fallback to creating a list with
// only the mode set up by the BIOS.
check_display_mode_hook limitModes = NULL;
if (gInfo->shared_info->device_type.Generation() < 4)
limitModes = limit_modes_for_gen3_lvds;
// TODO: support lower modes via scaling and windowing
gInfo->mode_list_area = create_display_modes("intel extreme modes",
NULL, &gInfo->shared_info->panel_mode, 1,
supportedSpaces, colorSpaceCount, NULL, &list, &count);
supportedSpaces, colorSpaceCount, limitModes, &list, &count);
} else {
// Otherwise return the 'real' list of modes
gInfo->mode_list_area = create_display_modes("intel extreme modes",
@ -247,7 +266,7 @@ intel_propose_display_mode(display_mode* target, const display_mode* low,
// first search for the specified mode in the list, if no mode is found
// try to fix the target mode in sanitize_display_mode
// TODO: Only sanitize_display_mode should be used. However, at the moments
// TODO: Only sanitize_display_mode should be used. However, at the moment
// the mode constraints are not optimal and do not work for all
// configurations.
for (uint32 i = 0; i < gInfo->shared_info->mode_count; i++) {