Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

userlandfs/server/fuse: Fix potential memory leak

Browse Source 
* Fix potential leak of 'cookie' at line 2206, which is allocated
  at line 2203. Pointed out by Clang Static Analyzer.
* Add NULL check to 'cookie'.

Change-Id: Ibfdbe3a52ceb0d29adf1acca51fb7b27d2c532f3
Reviewed-on: https://review.haiku-os.org/c/1065
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
This commit is contained in:
Murai Takashi 2019-02-14 06:31:50 +09:00 committed by waddlesplash
parent b7223dc11f
commit d938c7118f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/add-ons/kernel/file_systems/userlandfs/server/fuse/FUSEVolume.cpp
View File

@ -2201,9 +2201,13 @@ FUSEVolume::OpenAttr(void* _node, const char* name, int openMode,
} }
AttrCookie* cookie = new(std::nothrow)AttrCookie(name); AttrCookie* cookie = new(std::nothrow)AttrCookie(name);
if (cookie == NULL)
RETURN_ERROR(B_NO_MEMORY);
error = cookie->Allocate(attrSize); error = cookie->Allocate(attrSize);
if (error != B_OK) if (error != B_OK) {
delete cookie;
RETURN_ERROR(error); RETURN_ERROR(error);
}
int bytesRead = fuse_fs_getxattr(fFS, path, name, cookie->Buffer(), int bytesRead = fuse_fs_getxattr(fFS, path, name, cookie->Buffer(),
attrSize); attrSize);