From d6c852ec49df1af8400a62ab7a2eb950b50f1de0 Mon Sep 17 00:00:00 2001
From: Ryan Leavengood <leavengood@gmail.com>
Date: Sun, 19 Aug 2012 21:25:43 -0400
Subject: [PATCH] Actually cache something when CacheLocalizedName is called.

Before its name was a lie, since nothing was cached.

Another boolean was added because getting the localized name could fail, and we
don't want to pointlessly try again, so relying on fHasLocalizedName won't work
for that.

Since in my tests this was getting called up to 4 times per application when
opening the Deskbar Application menu, this caching should speed that up a bit,
at least when this file name translation feature is turned on.
---
 src/kits/tracker/Model.cpp | 28 ++++++++++++++++++----------
 src/kits/tracker/Model.h   |  1 +
 2 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/src/kits/tracker/Model.cpp b/src/kits/tracker/Model.cpp
index c0f2d285e2..1cf77c84ca 100644
--- a/src/kits/tracker/Model.cpp
+++ b/src/kits/tracker/Model.cpp
@@ -96,7 +96,8 @@ Model::Model()
 	fWritable(false),
 	fNode(NULL),
 	fStatus(B_NO_INIT),
-	fHasLocalizedName(false)
+	fHasLocalizedName(false),
+	fLocalizedNameIsCached(false)
 {
 }
 
@@ -111,7 +112,8 @@ Model::Model(const Model &cloneThis)
 	fWritable(false),
 	fNode(NULL),
 	fLocalizedName(cloneThis.fLocalizedName),
-	fHasLocalizedName(cloneThis.fHasLocalizedName)
+	fHasLocalizedName(cloneThis.fHasLocalizedName),
+	fLocalizedNameIsCached(cloneThis.fLocalizedNameIsCached)
 {
 	fStatBuf.st_dev = cloneThis.NodeRef()->device;
 	fStatBuf.st_ino = cloneThis.NodeRef()->node;
@@ -137,7 +139,8 @@ Model::Model(const node_ref* dirNode, const node_ref* node, const char* name,
 	fPreferredAppName(NULL),
 	fWritable(false),
 	fNode(NULL),
-	fHasLocalizedName(false)
+	fHasLocalizedName(false),
+	fLocalizedNameIsCached(false)
 {
 	SetTo(dirNode, node, name, open, writable);
 }
@@ -148,7 +151,8 @@ Model::Model(const BEntry* entry, bool open, bool writable)
 	fPreferredAppName(NULL),
 	fWritable(false),
 	fNode(NULL),
-	fHasLocalizedName(false)
+	fHasLocalizedName(false),
+	fLocalizedNameIsCached(false)
 {
 	SetTo(entry, open, writable);
 }
@@ -161,7 +165,8 @@ Model::Model(const entry_ref* ref, bool traverse, bool open, bool writable)
 	fIconFrom(kUnknownSource),
 	fWritable(false),
 	fNode(NULL),
-	fHasLocalizedName(false)
+	fHasLocalizedName(false),
+	fLocalizedNameIsCached(false)
 {
 	BEntry entry(ref, traverse);
 	fStatus = entry.InitCheck();
@@ -569,11 +574,14 @@ Model::SetupBaseType()
 void
 Model::CacheLocalizedName()
 {
-	if (BLocaleRoster::Default()->GetLocalizedFileName(
-			fLocalizedName, fEntryRef, true) == B_OK)
-		fHasLocalizedName = true;
-	else
-		fHasLocalizedName = false;
+	if (!fLocalizedNameIsCached) {
+		fLocalizedNameIsCached = true;
+		if (BLocaleRoster::Default()->GetLocalizedFileName(
+				fLocalizedName, fEntryRef, true) == B_OK)
+			fHasLocalizedName = true;
+		else
+			fHasLocalizedName = false;
+	}
 }
 
 
diff --git a/src/kits/tracker/Model.h b/src/kits/tracker/Model.h
index 1a872a7922..92307a758c 100644
--- a/src/kits/tracker/Model.h
+++ b/src/kits/tracker/Model.h
@@ -262,6 +262,7 @@ class Model {
 		status_t fStatus;
 		BString fLocalizedName;
 		bool fHasLocalizedName;
+		bool fLocalizedNameIsCached;
 };