From d30ac125dd6dc5d512f9bac50b37493b4e15031a Mon Sep 17 00:00:00 2001
From: Michael Lotz <mmlr@mlotz.ch>
Date: Mon, 29 May 2006 23:36:37 +0000
Subject: [PATCH] Respect the transfer direction. Control transfers with
 buffers work in both directions now.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17643 a95241bf-73f2-0310-859d-f6bbb57e9c96
---
 src/add-ons/kernel/busses/usb/uhci.cpp | 28 +++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/src/add-ons/kernel/busses/usb/uhci.cpp b/src/add-ons/kernel/busses/usb/uhci.cpp
index a37e21cda6..0d16002457 100644
--- a/src/add-ons/kernel/busses/usb/uhci.cpp
+++ b/src/add-ons/kernel/busses/usb/uhci.cpp
@@ -349,13 +349,14 @@ Queue::AddRequest(Transfer *transfer, bigtime_t timeout)
 		int32 packetSize = pipe->MaxPacketSize();
 		int32 bufferLength = transfer->BufferLength();
 		int32 descriptorCount = (bufferLength + packetSize - 1) / packetSize;
+		uint8 *buffer = (uint8 *)transfer->Buffer();
 
 		bool dataToggle = true;
 		uhci_td *lastDescriptor = NULL;
 		for (int32 i = 0; i < descriptorCount; i++) {
 			uhci_td *descriptor = new_descriptor(fStack, pipe,
 				directionIn ? TD_TOKEN_IN : TD_TOKEN_OUT,
-				min_c(packetSize, bufferLength), NULL);
+				min_c(packetSize, bufferLength), directionIn ? NULL : buffer);
 
 			if (!descriptor) {
 				free_descriptor_chain(setupDescriptor, fStack);
@@ -375,6 +376,9 @@ Queue::AddRequest(Transfer *transfer, bigtime_t timeout)
 			lastDescriptor = descriptor;
 			bufferLength -= packetSize;
 			dataToggle = !dataToggle;
+
+			if (!directionIn)
+				buffer += packetSize;
 		}
 
 		link_descriptors(lastDescriptor, statusDescriptor);
@@ -415,14 +419,24 @@ Queue::AddRequest(Transfer *transfer, bigtime_t timeout)
 					// without any error so we finished successfully
 					TRACE(("usb_uhci: transfer successful\n"));
 
-					uint8 *buffer = (uint8 *)transfer->Buffer();
+					if (!directionIn)
+						return B_OK;
+
 					int32 bufferSize = transfer->BufferLength();
+					if (bufferSize == 0)
+						return B_OK;
+
+					uint8 *buffer = (uint8 *)transfer->Buffer();
+					if (!buffer)
+						return B_ERROR;
+
+					size_t length = read_descriptor_chain(
+						(uhci_td *)setupDescriptor->link_log,
+						buffer, bufferSize);
+
 					size_t *actualLength = transfer->ActualLength();
-					if (buffer && bufferSize > 0) {
-						*actualLength = read_descriptor_chain(
-							(uhci_td *)setupDescriptor->link_log,
-							buffer, bufferSize);
-					}
+					if (actualLength)
+						*actualLength = length;
 
 					return B_OK;
 				}