Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CID1108404: missing array inintialization

Browse Source 
BuildReportList checks that the array does not already holds the reports
before adding them. If one of the uninitialized elements happened to be
the address of one of the reports, it would not get added again,
possibly leading to items in the array being in the wrong order. Just be
safe and clear the array.

Fixes #10221, patch there not used as it cluttered the code more than
needed.
This commit is contained in:
Adrien Destugues 2014-12-22 17:52:06 +01:00
parent d350b0f0d4
commit cd06fa402b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/add-ons/kernel/drivers/input/usb_hid/TabletProtocolHandler.cpp
View File

@ -147,7 +147,7 @@ TabletProtocolHandler::AddHandlers(HIDDevice &device, HIDCollection &collection,
return;
uint32 inputReportCount = 0;
HIDReport *inputReports[maxReportCount];
HIDReport *inputReports[maxReportCount] = {0};
collection.BuildReportList(HID_REPORT_TYPE_INPUT, inputReports,
inputReportCount);