Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

XHCI: Resolve TODO about referencing the specification in isochronous handling.

Browse Source
This commit is contained in:
Augustin Cavalier 2021-09-04 13:12:12 -04:00
parent 16414ce406
commit cadaf7583f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/add-ons/kernel/busses/usb/xhci.cpp
View File

@ -872,8 +872,9 @@ XHCI::SubmitNormalRequest(Transfer *transfer)
uint32 frame; uint32 frame;
if ((isochronousData->flags & USB_ISO_ASAP) != 0 if ((isochronousData->flags & USB_ISO_ASAP) != 0
|| isochronousData->starting_frame_number == NULL) { || isochronousData->starting_frame_number == NULL) {
// All reads from the microframe index register must be
// incremented by 1. (XHCI 1.2 § 4.14.2.1.4 p265.)
frame = ReadRunReg32(XHCI_MFINDEX) + 1; frame = ReadRunReg32(XHCI_MFINDEX) + 1;
// TODO: The +1 comes from the XHCI spec; document that.
td->trbs[0].flags |= TRB_3_ISO_SIA_BIT; td->trbs[0].flags |= TRB_3_ISO_SIA_BIT;
} else { } else {
frame = *isochronousData->starting_frame_number; frame = *isochronousData->starting_frame_number;