Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libroot: make mktemp() more random

Browse Source 
... by seeding rand() with process id, user id and current time.
This fix #13660
This commit is contained in:
Philippe Houdoin 2017-08-09 19:30:15 +00:00
parent ed8aae4664
commit c7a3a80cc6
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/system/libroot/posix/stdlib/mktemp.c
View File

@ -33,6 +33,7 @@
#include <sys/types.h>
#include <sys/stat.h>
#include <sys/time.h>
#include <fcntl.h>
#include <errno.h>
#include <stdio.h>
@ -96,6 +97,7 @@ _gettemp(char *path, int *doopen, int domkdir, int slen)
char *pad;
struct stat sbuf;
int rval;
struct timeval tv;
if (doopen != NULL && domkdir) {
__set_errno(EINVAL);
@ -114,6 +116,9 @@ _gettemp(char *path, int *doopen, int domkdir, int slen)
}
/* Fill space with random characters */
/* seed rand() first, otherwise generated sequences are same */
gettimeofday(&tv, 0);
srand((getpid() << 16) ^ getuid() ^ tv.tv_sec ^ tv.tv_usec);
while (trv >= path && *trv == 'X') {
uint32_t value = rand() % (sizeof(padchar) - 1);
*trv-- = padchar[value];