Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed #3043, which was listed as a ShowImage bug but really was a bug in

Browse Source 
several translators which used the incorrect MIME type for the base Be Bitmap
Format. Please when adding translators use image/x-be-bitmap, not just
x-be-bitmap. Though I suppose the if statement in ShowImage could be changed to
only look for x-be-bitmap at the end of the string when filtering, I think this
is the proper fix.

While I was editing the translators I also made the naming more consistant by
adding the translator name in parenthesis after Be Bitmap Format for those that
did not have it.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28487 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Ryan Leavengood 2008-11-04 06:10:14 +00:00
parent 01db1fe902
commit c095606e75
9 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/add-ons/translators/exr/EXRTranslator.cpp
View File

@ -34,8 +34,8 @@ translation_format sOutputFormats[] = {
B_TRANSLATOR_BITMAP,
BITS_OUT_QUALITY,
BITS_OUT_CAPABILITY,
"x-be-bitmap",
"Be Bitmap image"
"image/x-be-bitmap",
"Be Bitmap Format (EXRTranslator)"
},
};

6
src/add-ons/translators/gif/GIFTranslator.cpp
View File

@ -46,13 +46,13 @@ int32 translatorVersion = 0x140;
translation_format inputFormats[] = {
{ GIF_TYPE, B_TRANSLATOR_BITMAP, 0.8, 0.8, "image/gif", "GIF image" },
{ B_TRANSLATOR_BITMAP, B_TRANSLATOR_BITMAP, 0.3, 0.3, "image/x-be-bitmap", "Be Bitmap image" },
{ B_TRANSLATOR_BITMAP, B_TRANSLATOR_BITMAP, 0.3, 0.3, "image/x-be-bitmap", "Be Bitmap Format (GIFTranslator)" },
{ 0 }
};
translation_format outputFormats[] = {
{ GIF_TYPE, B_TRANSLATOR_BITMAP, 0.8, 0.8, "image/gif", "GIF image" },
{ B_TRANSLATOR_BITMAP, B_TRANSLATOR_BITMAP, 0.3, 0.3, "image/x-be-bitmap", "Be Bitmap image" },
{ B_TRANSLATOR_BITMAP, B_TRANSLATOR_BITMAP, 0.3, 0.3, "image/x-be-bitmap", "Be Bitmap Format (GIFTranslator)" },
{ 0 }
};
@ -156,7 +156,7 @@ Identify(BPositionIO *inSource, const translation_format *inFormat,
outInfo->type = B_TRANSLATOR_BITMAP;
outInfo->quality = 0.3;
outInfo->capability = 0.3;
strcpy(outInfo->name, "Be Bitmap image");
strcpy(outInfo->name, "Be Bitmap Format (GIFTranslator)");
strcpy(outInfo->MIME, "image/x-be-bitmap");
}
return B_OK;

4
src/add-ons/translators/hpgs/HPGSTranslator.cpp
View File

@ -60,8 +60,8 @@ translation_format sOutputFormats[] = {
B_TRANSLATOR_BITMAP,
BITS_OUT_QUALITY,
BITS_OUT_CAPABILITY,
"x-be-bitmap",
"Be Bitmap image"
"image/x-be-bitmap",
"Be Bitmap Format (HPGSTranslator)"
},
};

8
src/add-ons/translators/ico/ICOTranslator.cpp
View File

@ -35,8 +35,8 @@ translation_format sInputFormats[] = {
B_TRANSLATOR_BITMAP,
BITS_IN_QUALITY,
BITS_IN_CAPABILITY,
"x-be-bitmap",
"Be Bitmap image"
"images/x-be-bitmap",
"Be Bitmap Format (ICOTranslator)"
},
};
@ -55,8 +55,8 @@ translation_format sOutputFormats[] = {
B_TRANSLATOR_BITMAP,
BITS_OUT_QUALITY,
BITS_OUT_CAPABILITY,
"x-be-bitmap",
"Be Bitmap image"
"images/x-be-bitmap",
"Be Bitmap Format (ICOTranslator)"
},
};

2
src/add-ons/translators/jpeg/JPEGTranslator.cpp
View File

@ -47,7 +47,7 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// The translation kit's native file type
#define B_TRANSLATOR_BITMAP_MIME_STRING "image/x-be-bitmap"
#define B_TRANSLATOR_BITMAP_DESCRIPTION "Be Bitmap image"
#define B_TRANSLATOR_BITMAP_DESCRIPTION "Be Bitmap Format (JPEGTranslator)"
// Translation Kit required globals
char translatorName[] = "JPEG Images";

2
src/add-ons/translators/jpeg2000/JPEG2000Translator.cpp
View File

@ -45,7 +45,7 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// The translation kit's native file type
#define B_TRANSLATOR_BITMAP_MIME_STRING "image/x-be-bitmap"
#define B_TRANSLATOR_BITMAP_DESCRIPTION "Be Bitmap image"
#define B_TRANSLATOR_BITMAP_DESCRIPTION "Be Bitmap Format (JPEG2000Translator)"
// Translation Kit required globals
char translatorName[] = "JPEG2000 Images";

8
src/add-ons/translators/pcx/PCXTranslator.cpp
View File

@ -32,8 +32,8 @@ translation_format sInputFormats[] = {
B_TRANSLATOR_BITMAP,
BITS_IN_QUALITY,
BITS_IN_CAPABILITY,
"x-be-bitmap",
"Be Bitmap image"
"image/x-be-bitmap",
"Be Bitmap Format (PCXTranslator)"
},*/
};
@ -52,8 +52,8 @@ translation_format sOutputFormats[] = {
B_TRANSLATOR_BITMAP,
BITS_OUT_QUALITY,
BITS_OUT_CAPABILITY,
"x-be-bitmap",
"Be Bitmap image"
"image/x-be-bitmap",
"Be Bitmap Format (PCXTranslator)"
},
};

6
src/add-ons/translators/ppm/PPMTranslator.cpp
View File

@ -62,13 +62,13 @@ int32 translatorVersion = PPM_TRANSLATOR_VERSION;
/* These two data arrays are a really good idea to export from Translators, but not required. */
translation_format inputFormats[] = {
{ B_TRANSLATOR_BITMAP, B_TRANSLATOR_BITMAP, 0.4, 0.8, "image/x-be-bitmap", "Be Bitmap image" },
{ B_TRANSLATOR_BITMAP, B_TRANSLATOR_BITMAP, 0.4, 0.8, "image/x-be-bitmap", "Be Bitmap Format (PPMTranslator)" },
{ PPM_TYPE, B_TRANSLATOR_BITMAP, 0.3, 0.8, "image/x-portable-pixmap", "PPM image" },
{ 0, 0, 0, 0, "\0", "\0" }
}; /* optional (else Identify is always called) */
translation_format outputFormats[] = {
{ B_TRANSLATOR_BITMAP, B_TRANSLATOR_BITMAP, 0.4, 0.8, "image/x-be-bitmap", "Be Bitmap image" },
{ B_TRANSLATOR_BITMAP, B_TRANSLATOR_BITMAP, 0.4, 0.8, "image/x-be-bitmap", "Be Bitmap Format (PPMTranslator)" },
{ PPM_TYPE, B_TRANSLATOR_BITMAP, 0.3, 0.8, "image/x-portable-pixmap", "PPM image" },
{ 0, 0, 0, 0, "\0", "\0" }
}; /* optional (else Translate is called anyway) */
@ -269,7 +269,7 @@ Identify( /* required */
outInfo->type = B_TRANSLATOR_BITMAP;
outInfo->quality = 0.4; /* B_TRANSLATOR_BITMAP can do alpha, at least */
outInfo->capability = 0.8; /* and we might not know many variations thereof */
strcpy(outInfo->name, "Be Bitmap image");
strcpy(outInfo->name, "Be Bitmap Format (PPMTranslator)");
strcpy(outInfo->MIME, "image/x-be-bitmap"); /* this is the MIME type of B_TRANSLATOR_BITMAP */
}
return B_OK;

4
src/add-ons/translators/raw/RAWTranslator.cpp
View File

@ -71,8 +71,8 @@ translation_format sOutputFormats[] = {
B_TRANSLATOR_BITMAP,
BITS_OUT_QUALITY,
BITS_OUT_CAPABILITY,
"x-be-bitmap",
"Be Bitmap image"
"image/x-be-bitmap",
"Be Bitmap Format (RAWTranslator)"
},
};