Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

removed useless sprintf() call, added a TODO

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27845 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stefano Ceccherini 2008-10-03 06:25:28 +00:00
parent 4e0c2a797d
commit bcdc0267c6
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/add-ons/kernel/bus_managers/acpi/acpi_ns_dump.c
View File

@ -20,7 +20,8 @@ typedef struct acpi_ns_device_info {
static void
dump_acpi_namespace(acpi_ns_device_info *device, char *root, void *buf, size_t* num_bytes, int indenting) {
dump_acpi_namespace(acpi_ns_device_info *device, char *root, void *buf, size_t* num_bytes, int indenting)
{
char result[255];
char output[255];
char tabs[255];
@ -89,8 +90,9 @@ dump_acpi_namespace(acpi_ns_device_info *device, char *root, void *buf, size_t*
sprintf(output, "%s BUFFER_FIELD", output);
break;
}
sprintf(output, "%s\n", output);
// TODO: This is obviously broken!
// We should respect "*num_bytes", otherwise
// we could have a buffer overflow. See ticket #2786
sprintf((buf + *num_bytes), "%s", output);
*num_bytes += strlen(output);