Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ps2_dev encapsulate TRACING code

Browse Source 
Avoid doing system_time() calls in a loop.
Is this even needed anymore?
This commit is contained in:
Fredrik Holmqvist 2018-08-24 13:51:48 +02:00
parent 5aff790ae1
commit b2e0398cd4
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/add-ons/kernel/bus_managers/ps2/ps2_dev.cpp
View File

@ -368,7 +368,9 @@ standard_command_timeout(ps2_dev* dev, uint8 cmd, const uint8* out,
int out_count, uint8* in, int in_count, bigtime_t timeout)
{
status_t res;
#ifdef TRACE_PS2
bigtime_t start;
#endif
int32 sem_count;
int i;
@ -426,16 +428,18 @@ standard_command_timeout(ps2_dev* dev, uint8 cmd, const uint8* out,
}
release_sem(gControllerSem);
#ifdef TRACE_PS2
start = system_time();
#endif
res = acquire_sem_etc(dev->result_sem, 1, B_RELATIVE_TIMEOUT, timeout);
if (res != B_OK)
atomic_and(&dev->flags, ~PS2_FLAG_CMD);
#ifdef TRACE_PS2
TRACE("ps2: ps2_dev_command wait for ack res 0x%08" B_PRIx32 ", "
"wait-time %" B_PRId64 "\n", res, system_time() - start);
#endif
if (atomic_get(&dev->flags) & PS2_FLAG_ACK) {
TRACE("ps2: ps2_dev_command got ACK\n");
}
@ -454,7 +458,9 @@ standard_command_timeout(ps2_dev* dev, uint8 cmd, const uint8* out,
if (in_count == 0) {
atomic_and(&dev->flags, ~PS2_FLAG_CMD);
} else {
#ifdef TRACE_PS2
start = system_time();
#endif
res = acquire_sem_etc(dev->result_sem, 1, B_RELATIVE_TIMEOUT,
timeout);
@ -468,11 +474,12 @@ standard_command_timeout(ps2_dev* dev, uint8 cmd, const uint8* out,
res = B_IO_ERROR;
}
#ifdef TRACE_PS2
TRACE("ps2: ps2_dev_command wait for input res 0x%08" B_PRIx32 ", "
"wait-time %" B_PRId64 "\n", res, system_time() - start);
for (i = 0; i < in_count; i++)
TRACE("ps2: ps2_dev_command rx: 0x%02x\n", in[i]);
#endif
}
}