Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

linkcatkeys: Avoid discarding potential error values.

Browse Source 
Spotted by Clang and the [[nodiscard]] patch.
This commit is contained in:
Augustin Cavalier 2019-08-02 19:14:57 -04:00
parent dfbf1c8a0a
commit afb345915d
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/tools/locale/linkcatkeys.cpp
View File

@ -127,8 +127,9 @@ main(int argc, char **argv)
case TARGET_ATTRIBUTE: {
BEntry entry(outputFile.String());
entry_ref eref;
entry.GetRef(&eref);
res = targetCatImpl.WriteToAttribute(eref);
res = entry.GetRef(&eref);
if (res == B_OK)
res = targetCatImpl.WriteToAttribute(eref);
if (res != B_OK) {
fprintf(stderr,
"couldn't write target-attribute to %s - error: %s\n",
@ -140,8 +141,9 @@ main(int argc, char **argv)
case TARGET_RESOURCE: {
BEntry entry(outputFile.String());
entry_ref eref;
entry.GetRef(&eref);
res = targetCatImpl.WriteToResource(eref);
res = entry.GetRef(&eref);
if (res == B_OK)
res = targetCatImpl.WriteToResource(eref);
if (res != B_OK) {
fprintf(stderr,
"couldn't write target-resource to %s - error: %s\n",