Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IconCache: remove incorrect ASSERT()

Browse Source 
The code does just fine both if entry is NULL and if it doesn't have an
icon. However, if entry is NULL, this assert calls a method on it, which
is a bad idea.

Change-Id: I80b314db373970d99eb008aeaec6254d14c39ca7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1749
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>
This commit is contained in:
Adrien Destugues 2019-08-26 21:32:57 +02:00 committed by Stephan Aßmus
parent b9d9c282fd
commit ab56137e24
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/kits/tracker/IconCache.cpp
View File

@ -1007,7 +1007,6 @@ IconCache::Preload(AutoLock<SimpleIconCache>* nodeCacheLocker,
entry = GetIconFromFileTypes(&modelOpener, source, mode,
size, &lazyBitmap, 0);
ASSERT(entry != NULL || entry->HaveIconBitmap(mode, size));
if (entry == NULL || !entry->HaveIconBitmap(mode, size)) {
// we don't have an icon, go with the generic