From a94ee3f35a29042e0cfbc31dcf9f6a39ceda2845 Mon Sep 17 00:00:00 2001 From: Adrien Destugues Date: Sun, 25 Jul 2021 13:49:44 +0200 Subject: [PATCH] BUrlRequest: fix issues found while documenting - Remove Pause/Resume functions. They are not possible to implement (the server would time out) - Fix SetContext(NULL) to do the right thing. Change-Id: I25ba09bb01ea0fe8a85d774611b33be7dc192028 Reviewed-on: https://review.haiku-os.org/c/haiku/+/4245 Tested-by: Commit checker robot Reviewed-by: Niels Sascha Reedijk --- headers/private/netservices/UrlRequest.h | 2 -- .../network/libnetservices/UrlRequest.cpp | 22 +++++-------------- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/headers/private/netservices/UrlRequest.h b/headers/private/netservices/UrlRequest.h index 993bdfe118..94010edd33 100644 --- a/headers/private/netservices/UrlRequest.h +++ b/headers/private/netservices/UrlRequest.h @@ -40,8 +40,6 @@ public: // URL protocol thread management virtual thread_id Run(); - virtual status_t Pause(); - virtual status_t Resume(); virtual status_t Stop(); virtual void SetTimeout(bigtime_t timeout) {} diff --git a/src/kits/network/libnetservices/UrlRequest.cpp b/src/kits/network/libnetservices/UrlRequest.cpp index fa67851af0..00b6afb6a7 100644 --- a/src/kits/network/libnetservices/UrlRequest.cpp +++ b/src/kits/network/libnetservices/UrlRequest.cpp @@ -98,22 +98,6 @@ BUrlRequest::Run() } -status_t -BUrlRequest::Pause() -{ - // TODO - return B_ERROR; -} - - -status_t -BUrlRequest::Resume() -{ - // TODO - return B_ERROR; -} - - status_t BUrlRequest::Stop() { @@ -146,7 +130,11 @@ BUrlRequest::SetContext(BUrlContext* context) if (IsRunning()) return B_ERROR; - fContext = context; + if (context == NULL) + fContext = gDefaultContext; + else + fContext = context; + return B_OK; }