Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Coverity] Fixed some uninit fields and return values checks

Browse Source 
* Fixed CID2398, CID9945, CID9943, CID4215
This commit is contained in:
Siarzhuk Zharski 2012-02-02 22:02:53 +01:00
parent 1acd796b6b
commit a2f89c5843
5 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/apps/terminal/AppearPrefView.cpp
View File

@ -492,7 +492,9 @@ AppearancePrefView::_MakeMenu(uint32 msg, const char** items,
i++; i++;
} }
menu->FindItem(defaultItemName)->SetMarked(true); BMenuItem* defaultItem = menu->FindItem(defaultItemName);
if (defaultItem)
defaultItem->SetMarked(true);
return menu; return menu;
} }

13
src/apps/terminal/BasicTerminalBuffer.cpp
View File

@ -98,9 +98,20 @@ BasicTerminalBuffer::_CursorChanged()
BasicTerminalBuffer::BasicTerminalBuffer() BasicTerminalBuffer::BasicTerminalBuffer()
: :
fWidth(0),
fHeight(0),
fScrollTop(0),
fScrollBottom(0),
fScreen(NULL), fScreen(NULL),
fScreenOffset(0),
fHistory(NULL), fHistory(NULL),
fTabStops(NULL) fSoftWrappedCursor(false),
fOverwriteMode(false),
fAlternateScreenActive(false),
fOriginMode(false),
fSavedOriginMode(false),
fTabStops(NULL),
fEncoding(M_UTF8)
{ {
} }

5
src/apps/terminal/BasicTerminalBuffer.h
View File

@ -45,6 +45,11 @@ struct TerminalBufferDirtyInfo {
invalidateAll = false; invalidateAll = false;
messageSent = false; messageSent = false;
} }
TerminalBufferDirtyInfo()
{
Reset();
}
}; };

2
src/apps/terminal/TermParse.cpp
View File

@ -83,6 +83,8 @@ TermParse::TermParse(int fd)
fBuffer(NULL), fBuffer(NULL),
fQuitting(true) fQuitting(true)
{ {
memset(fReadBuffer, 0, READ_BUF_SIZE);
memset(fParserBuffer, 0, ESC_PARSER_BUFFER_SIZE);
} }

8
src/apps/terminal/TermView.cpp
View File

@ -1858,8 +1858,8 @@ TermView::MessageReceived(BMessage *msg)
int32 i; int32 i;
int32 encodingID; int32 encodingID;
BMessage specifier; BMessage specifier;
msg->GetCurrentSpecifier(&i, &specifier); if (msg->GetCurrentSpecifier(&i, &specifier) == B_OK
if (!strcmp("encoding", specifier.FindString("property", i))){ && !strcmp("encoding", specifier.FindString("property", i))) {
msg->FindInt32 ("data", &encodingID); msg->FindInt32 ("data", &encodingID);
SetEncoding(encodingID); SetEncoding(encodingID);
msg->SendReply(B_REPLY); msg->SendReply(B_REPLY);
@ -1873,8 +1873,8 @@ TermView::MessageReceived(BMessage *msg)
{ {
int32 i; int32 i;
BMessage specifier; BMessage specifier;
msg->GetCurrentSpecifier(&i, &specifier); if (msg->GetCurrentSpecifier(&i, &specifier) == B_OK
if (!strcmp("encoding", specifier.FindString("property", i))){ && !strcmp("encoding", specifier.FindString("property", i))) {
BMessage reply(B_REPLY); BMessage reply(B_REPLY);
reply.AddInt32("result", Encoding()); reply.AddInt32("result", Encoding());
msg->SendReply(&reply); msg->SendReply(&reply);