Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cdda: got rid of kernel_cpp.h - it should not be used.

Browse Source 
* It's "new" operator does not fail or throw on allocation problems, but
  just lets the constructor do its work (and likely crash because of
  accessing a null pointer).
This commit is contained in:
Axel Dörfler 2013-10-13 23:40:59 +02:00
parent 9499ef8e51
commit a2d3d3ae54
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/add-ons/kernel/file_systems/cdda/kernel_interface.cpp
View File

@ -19,7 +19,6 @@
#include <NodeMonitor.h> #include <NodeMonitor.h>
#include <TypeConstants.h> #include <TypeConstants.h>
#include <util/kernel_cpp.h>
#include <util/DoublyLinkedList.h> #include <util/DoublyLinkedList.h>
#include "cdda.h" #include "cdda.h"
@ -432,7 +431,7 @@ read_attributes(int fd, Inode* inode)
size = B_BENDIAN_TO_HOST_INT32(size); size = B_BENDIAN_TO_HOST_INT32(size);
name[length] = '\0'; name[length] = '\0';
Attribute* attribute = new Attribute(name, type); Attribute* attribute = new(std::nothrow) Attribute(name, type);
if (attribute->IsProtectedNamespace()) { if (attribute->IsProtectedNamespace()) {
// Attributes in the protected namespace are handled internally // Attributes in the protected namespace are handled internally
// so we do not load them even if they are present in the // so we do not load them even if they are present in the
@ -853,7 +852,8 @@ Inode*
Volume::_CreateNode(Inode* parent, const char* name, uint64 start, Volume::_CreateNode(Inode* parent, const char* name, uint64 start,
uint64 frames, int32 type) uint64 frames, int32 type)
{ {
Inode* inode = new Inode(this, parent, name, start, frames, type); Inode* inode = new(std::nothrow) Inode(this, parent, name, start, frames,
type);
if (inode == NULL) if (inode == NULL)
return NULL; return NULL;
@ -1276,7 +1276,7 @@ status_t
Inode::AddAttribute(const char* name, type_code type, bool overwrite, Inode::AddAttribute(const char* name, type_code type, bool overwrite,
const uint8* data, size_t length) const uint8* data, size_t length)
{ {
Attribute* attribute = new Attribute(name, type); Attribute* attribute = new(std::nothrow) Attribute(name, type);
if (attribute == NULL) if (attribute == NULL)
return B_NO_MEMORY; return B_NO_MEMORY;
@ -1476,7 +1476,7 @@ cdda_mount(fs_volume* fsVolume, const char* device, uint32 flags,
{ {
TRACE(("cdda_mount: entry\n")); TRACE(("cdda_mount: entry\n"));
Volume* volume = new Volume(fsVolume); Volume* volume = new(std::nothrow) Volume(fsVolume);
if (volume == NULL) if (volume == NULL)
return B_NO_MEMORY; return B_NO_MEMORY;