Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixing CID 1305: the null check of fPageFormatText on line 483 was redundant

Browse Source 
since fPageFormatText is accessed in both branches of the if before the null
check. If it was actually null there would be a crash well before line 483. In
addition this member is initialized in the constructor. I assume the null check
was added to provide symmetry with the null check of fJobSetupText below it.
But that latter null check is needed since fJobSetupText may not have been
created in the constructor.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27427 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Ryan Leavengood 2008-09-12 04:13:30 +00:00
parent dcddeb4c1c
commit 9b54ac7464
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/servers/print/ConfigWindow.cpp
View File

@ -480,10 +480,9 @@ void ConfigWindow::UpdateUI()
fJobSetupText->ResizeToPreferred();
}
}
if (fPageFormatText) {
if (fOk->Frame().right < fPageFormatText->Frame().right)
ResizeTo(fPageFormatText->Frame().right + 10, Bounds().bottom);
}
if (fOk->Frame().right < fPageFormatText->Frame().right)
ResizeTo(fPageFormatText->Frame().right + 10, Bounds().bottom);
if (fJobSetupText) {
if (fOk->Frame().right < fJobSetupText->Frame().right)