From 92af28df98183cf8031df6513ed015615be0c489 Mon Sep 17 00:00:00 2001 From: Ingo Weinhold Date: Mon, 24 Mar 2008 02:31:20 +0000 Subject: [PATCH] Turned the note into a TODO, adding a thought how to implement it. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24546 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/system/runtime_loader/elf.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/system/runtime_loader/elf.cpp b/src/system/runtime_loader/elf.cpp index eaa3b6ed94..5480882fa6 100644 --- a/src/system/runtime_loader/elf.cpp +++ b/src/system/runtime_loader/elf.cpp @@ -1022,8 +1022,10 @@ find_undefined_symbol(image_t* rootImage, image_t* image, const char* name, image_t** foundInImage) { // If not simulating BeOS style symbol resolution, undefined symbols are - // search recursively starting from the root image. (Note, breadth first - // might be better than the depth first use here.) + // searched recursively starting from the root image. + // TODO: Breadth first might be better than the depth first strategy used + // here. We're also visiting images multiple times. Consider building a + // breadth-first sorted array of images for each root image. if ((rootImage->flags & IMAGE_FLAG_R5_SYMBOL_RESOLUTION) == 0) { Elf32_Sym* symbol = find_symbol_recursively(rootImage, name, foundInImage);