From 8bb337b5fe7269387cd381652c9cbf254fcfdda5 Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Sat, 29 Jun 2019 15:18:27 -0400 Subject: [PATCH] libnvme: make configure_aer failing a warning. The spec generally requires this feature, but some emulated hardware (e.g. QEMU) does not support it. SPDK seems to just ignore the error and continue on with a warning, so let's do the same here. --- src/add-ons/kernel/drivers/disk/nvme/libnvme/nvme_ctrlr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/add-ons/kernel/drivers/disk/nvme/libnvme/nvme_ctrlr.c b/src/add-ons/kernel/drivers/disk/nvme/libnvme/nvme_ctrlr.c index 81a31e48fd..cdaa3b7b6c 100644 --- a/src/add-ons/kernel/drivers/disk/nvme/libnvme/nvme_ctrlr.c +++ b/src/add-ons/kernel/drivers/disk/nvme/libnvme/nvme_ctrlr.c @@ -700,7 +700,7 @@ static int nvme_ctrlr_start(struct nvme_ctrlr *ctrlr) return -1; if (nvme_ctrlr_configure_aer(ctrlr) != 0) - return -1; + nvme_warning("controller does not support AER!\n"); nvme_ctrlr_set_supported_log_pages(ctrlr); nvme_ctrlr_set_supported_features(ctrlr);