Added TODO regarding serious locking problem.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28192 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
parent
471844b258
commit
8a05bb865f
|
@ -127,6 +127,10 @@ public:
|
||||||
queueLocker->Unlock();
|
queueLocker->Unlock();
|
||||||
|
|
||||||
InterruptsSpinLocker _(gThreadSpinlock);
|
InterruptsSpinLocker _(gThreadSpinlock);
|
||||||
|
// TODO: We've got a serious race condition: If BlockAndUnlock() returned due to
|
||||||
|
// interruption, we will still be queued. A WakeUpThread() at this point will
|
||||||
|
// call thread_unblock() and might thus screw with our trying to re-lock the
|
||||||
|
// mutex.
|
||||||
return thread_block_locked(thread);
|
return thread_block_locked(thread);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -144,6 +144,10 @@ public:
|
||||||
setLocker->Unlock();
|
setLocker->Unlock();
|
||||||
|
|
||||||
InterruptsSpinLocker _(gThreadSpinlock);
|
InterruptsSpinLocker _(gThreadSpinlock);
|
||||||
|
// TODO: We've got a serious race condition: If BlockAndUnlock() returned due to
|
||||||
|
// interruption, we will still be queued. A WakeUpThread() at this point will
|
||||||
|
// call thread_unblock() and might thus screw with our trying to re-lock the
|
||||||
|
// mutex.
|
||||||
return thread_block_locked(thread);
|
return thread_block_locked(thread);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue