Aren
/
haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tracker: Fix use-after-free in info window attribute view dtor. 

The model was owned by the info window and is gone at the point where
the AttributeView is destroyed. Since the extra check whether the model
is a symlink isn't really needed at all, I opted to just remove it
instead of destroying the AttributeView sooner or unsetting its model.
This commit is contained in:
Michael Lotz 2015-04-18 14:11:19 +02:00
parent 359d64ed66
commit 859686a51c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/kits/tracker/InfoWindow.cpp
View File

@ -990,7 +990,7 @@ AttributeView::~AttributeView()
if (fDescWindow->Lock())
fDescWindow->Quit();
if (fModel->IsSymLink() && fIconModel != fModel)
if (fIconModel != fModel)
delete fIconModel;
}