Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vfs: fail only truncate on file descriptors opened read-only.

Browse Source 
chmod is allowed.

Change-Id: Idcac38bdd7f0d614538421a41dfd30066a0c316f
Reviewed-on: https://review.haiku-os.org/c/1444
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
This commit is contained in:
Jérôme Duval 2019-05-10 20:42:20 +02:00 committed by Adrien Destugues
parent 00b283c042
commit 858e5775ab
3 changed files with 55 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/system/kernel/fs/vfs.cpp
View File

@ -26,6 +26,7 @@
#include <fs_info.h>
#include <fs_interface.h>
#include <fs_volume.h>
#include <NodeMonitor.h>
#include <OS.h>
#include <StorageDefs.h>
@ -6606,8 +6607,10 @@ common_write_stat(struct file_descriptor* descriptor, const struct stat* stat,
FUNCTION(("common_write_stat(vnode = %p, stat = %p, statMask = %d)\n",
vnode, stat, statMask));
if ((descriptor->open_mode & O_RWMASK) == O_RDONLY)
if ((descriptor->open_mode & O_RWMASK) == O_RDONLY
&& (statMask & B_STAT_SIZE) != 0) {
return B_BAD_VALUE;
}
if (!HAS_FS_CALL(vnode, write_stat))
return B_READ_ONLY_DEVICE;

1
src/tests/system/libroot/posix/Jamfile
View File

@ -11,6 +11,7 @@ SimpleTest abort_test : abort_test.cpp ;
SimpleTest SyslogTest : SyslogTest.cpp ;
SimpleTest brk_test : brk_test.c ;
SimpleTest calloc_test : calloc_test.c ;
SimpleTest <test>chmod : chmod.cpp ;
SimpleTest clearenv : clearenv.cpp ;
SimpleTest dirent_test : dirent_test.cpp ;
SimpleTest flock_test : flock_test.cpp ;

50
src/tests/system/libroot/posix/chmod.cpp Normal file
View File

@ -0,0 +1,50 @@
/*
* Copyright 2008, Axel Dörfler, axeld@pinc-software.de.
* Distributed under the terms of the MIT License.
*/
#include <ctype.h>
#include <errno.h>
#include <fcntl.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/stat.h>
#include <unistd.h>
extern const char *__progname;
int
main(int argc, char **argv)
{
if (argc < 3) {
fprintf(stderr, "usage: %s <file> <size>\n", __progname);
return 1;
}
struct stat st;
if (stat(argv[1], &st) != 0) {
fprintf(stderr, "%s: cannot stat file \"%s\": %s\n", __progname,
argv[1], strerror(errno));
return 1;
}
int fd = open(argv[1], O_RDONLY);
if (fd < 0) {
fprintf(stderr, "%s: could open the file read-only \"%s\": %s\n",
__progname, argv[1], strerror(errno));
return 1;
}
if (fchmod(fd, 0666) == -1) {
fprintf(stderr, "%s: couldn't chmod a file opened read-only \"%s\": %s\n",
__progname, argv[1], strerror(errno));
close(fd);
return 1;
}
close(fd);
return 0;
}