Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid calling PenLocation for every char.

Browse Source 
PenLocation is retrieved from app_server (because DrawString changes it
there), so this made drawing very slow.
This commit is contained in:
Adrien Destugues 2014-08-13 12:44:13 +02:00
parent 30636d2eb6
commit 7e03464586
1 changed files with 21 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/apps/serialconnect/TermView.cpp
View File

@ -47,21 +47,8 @@ TermView::~TermView()
void
TermView::AttachedToWindow()
{
BView::AttachedToWindow();
MakeFocus();
VTermScreenCell cell;
VTermPos firstPos;
firstPos.row = 0;
firstPos.col = 0;
_GetCell(firstPos, cell);
rgb_color background;
background.red = cell.bg.red;
background.green = cell.bg.green;
background.blue = cell.bg.blue;
background.alpha = 255;
SetViewColor(background);
}
@ -110,15 +97,14 @@ TermView::Draw(BRect updateRect)
SetHighColor(foreground);
}
BPoint penLocation = PenLocation();
FillRect(BRect(penLocation.x,
penLocation.y - ceil(height.ascent) + 1,
penLocation.x + cell.width * fFontWidth - 1,
penLocation.y + ceil(height.descent) + ceil(height.leading)),
FillRect(BRect(x,
y - ceil(height.ascent) + 1,
x + cell.width * fFontWidth - 1,
y + ceil(height.descent) + ceil(height.leading)),
B_SOLID_LOW);
if (cell.chars[0] == 0) {
DrawString(" ");
x += fFontWidth;
pos.col ++;
} else {
char buffer[VTERM_MAX_CHARS_PER_CELL];
@ -126,6 +112,7 @@ TermView::Draw(BRect updateRect)
VTERM_MAX_CHARS_PER_CELL);
DrawString(buffer);
x += StringWidth(buffer);
pos.col += cell.width;
}
}
@ -209,6 +196,20 @@ TermView::_Init()
vterm_screen_reset(fTermScreen, 1);
vterm_parser_set_utf8(fTerm, 1);
VTermScreenCell cell;
VTermPos firstPos;
firstPos.row = 0;
firstPos.col = 0;
_GetCell(firstPos, cell);
rgb_color background;
background.red = cell.bg.red;
background.green = cell.bg.green;
background.blue = cell.bg.blue;
background.alpha = 255;
SetViewColor(background);
}