From 78614977b012fa2f84d34bb6c3abe93a407f214e Mon Sep 17 00:00:00 2001 From: Philippe Saint-Pierre Date: Sun, 6 May 2012 20:00:15 -0400 Subject: [PATCH] Tracker: Removing the Desktop Background Image don't clear a pointer fBackgroundImage wasn't being cleared when removing the desktop background image because the loading process wasn't ignoring loading failures (as is the "no background for this workspace" setting). fBackgroundImage not being NULL was causing crashes mainly in ScreenChanged(), where it was trying to re-center a non-existant background. Was causing #7376 and maybe others. --- src/kits/tracker/BackgroundImage.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/kits/tracker/BackgroundImage.cpp b/src/kits/tracker/BackgroundImage.cpp index bc61a3fecb..565ee90dc3 100644 --- a/src/kits/tracker/BackgroundImage.cpp +++ b/src/kits/tracker/BackgroundImage.cpp @@ -93,6 +93,7 @@ BackgroundImage::GetBackgroundImage(const BNode *node, bool isDesktop) bitmap = BTranslationUtils::GetBitmap(path); if (!bitmap) { PRINT(("failed to load background bitmap from path\n")); + continue; } } else break;