Revert "Fix gcc2 build on Mac OS X Lion"

now that Alex Smith has fixed the build system on Lion this
work-around can now be reverted.

This reverts commit 7c369a4b3f.
This commit is contained in:
John Scipione 2012-07-30 02:10:08 -04:00
parent c15ad4e6b9
commit 78341a9351
4 changed files with 16 additions and 32 deletions

View File

@ -102,14 +102,6 @@ protected:
void SetupErrorBuffer(int x, int y, int width); void SetupErrorBuffer(int x, int y, int width);
void DitherFloydSteinberg(uchar* destination, void DitherFloydSteinberg(uchar* destination,
const uchar* source, int x, int y, int width); const uchar* source, int x, int y, int width);
// Do nothing method to get around a bug in
// the gcc2 cross-compiler built on Mac OS X
// Lion where a compiler error occurs when
// assigning a member function pointer to NULL
// or 0: cast specifies signature type.
// However, this should be legal according to
// the C++03 standard.
void DitherNone(uchar*, const uchar*, int, int, int) {};
private: private:
enum { enum {

View File

@ -21,7 +21,7 @@
Resampler::Resampler(uint32 src_format, uint32 dst_format) Resampler::Resampler(uint32 src_format, uint32 dst_format)
: :
fFunc(&Resampler::no_conversion) fFunc(0)
{ {
if (dst_format == media_raw_audio_format::B_AUDIO_FLOAT) { if (dst_format == media_raw_audio_format::B_AUDIO_FLOAT) {
switch (src_format) { switch (src_format) {
@ -81,7 +81,7 @@ Resampler::~Resampler()
status_t status_t
Resampler::InitCheck() const Resampler::InitCheck() const
{ {
return fFunc != &Resampler::no_conversion ? B_OK : B_ERROR; return fFunc != 0 ? B_OK : B_ERROR;
} }

View File

@ -65,15 +65,6 @@ private:
int32 srcSampleOffset, int32 srcSampleCount, int32 srcSampleOffset, int32 srcSampleCount,
void* dest, int32 destSampleOffset, void* dest, int32 destSampleOffset,
int32 destSampleCount, float gain); int32 destSampleCount, float gain);
// Do nothing method to get around a bug in
// the gcc2 cross-compiler built on Mac OS X
// Lion where a compiler error occurs when
// assigning a member function pointer to NULL
// or 0: cast specifies signature type.
// However, this should be legal according to
// the C++03 standard.
void no_conversion(const void*, int32, int32, void*,
int32, int32, float) {};
}; };

View File

@ -84,7 +84,7 @@ Halftone::Halftone(color_space colorSpace, double gamma, double min,
fDither = &Halftone::DitherRGB32; fDither = &Halftone::DitherRGB32;
break; break;
default: default:
fDither = &Halftone::DitherNone; fDither = NULL;
break; break;
} }
} }
@ -364,3 +364,4 @@ Halftone::DitherFloydSteinberg(uchar *destination, const uchar* source0,
*destination = ConvertUsingBlackValue(cur); *destination = ConvertUsingBlackValue(cur);
} }
} }