From 74983a5f69cef9ef4e0d316ec79123e7015b3256 Mon Sep 17 00:00:00 2001 From: Philippe Saint-Pierre Date: Sat, 7 Jan 2012 20:42:19 -0500 Subject: [PATCH] shortcut_catcher: memory leak fixes memory allocated in get_key_map(..) wasn't released. CID 5696, CID 5697, CID 1699, CID 1700 --- .../filters/shortcut_catcher/CommandActuators.cpp | 2 ++ .../input_server/filters/shortcut_catcher/KeyInfos.cpp | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/add-ons/input_server/filters/shortcut_catcher/CommandActuators.cpp b/src/add-ons/input_server/filters/shortcut_catcher/CommandActuators.cpp index af53a9d314..6f72dfcf29 100644 --- a/src/add-ons/input_server/filters/shortcut_catcher/CommandActuators.cpp +++ b/src/add-ons/input_server/filters/shortcut_catcher/CommandActuators.cpp @@ -797,6 +797,8 @@ KeyStrokeSequenceCommandActuator::_GenerateKeyCodes() _SetStateBit(states, overrideKey); } } + free(keys); + free(map); } diff --git a/src/add-ons/input_server/filters/shortcut_catcher/KeyInfos.cpp b/src/add-ons/input_server/filters/shortcut_catcher/KeyInfos.cpp index ab20c61391..5174b4fb59 100644 --- a/src/add-ons/input_server/filters/shortcut_catcher/KeyInfos.cpp +++ b/src/add-ons/input_server/filters/shortcut_catcher/KeyInfos.cpp @@ -11,6 +11,7 @@ #include +#include #include #include @@ -102,7 +103,7 @@ static const char* FindSpecialKeyLabelFor(uint8 keyCode, int& last) { while ((keyLabels[last].fKeyCode < keyCode) - && (last < (sizeof(keyLabels)/sizeof(struct KeyLabelMap))-1)) + && (last < (sizeof(keyLabels) / sizeof(struct KeyLabelMap)) - 1)) last++; if (keyLabels[last].fKeyCode == keyCode) @@ -151,6 +152,8 @@ InitKeyIndices() } else utfDescriptions[j * MAX_UTF8_LENGTH] = 0x00; } + free(keys); + free(map); }