Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

XHCI: Properly handle partially-failed transfers.

Browse Source
This commit is contained in:
Augustin Cavalier 2019-03-09 17:53:31 -05:00
parent c5c392585c
commit 7356f1de4b
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/add-ons/kernel/busses/usb/xhci.cpp
View File

@ -2223,7 +2223,9 @@ XHCI::HandleTransferComplete(xhci_trb* trb)
// The TRB at offset trb_used will be the link TRB, which we do not
// care about (and should not generate an interrupt at all.)
// We really care about the properly last TRB, at index "count - 1".
if (offset == td->trb_used - 1) {
// Additionally, if we have an unsuccessful completion code, the transfer
// likely failed midway; so just accept it anyway.
if (offset == (td->trb_used - 1) || completionCode != COMP_SUCCESS) {
_UnlinkDescriptorForPipe(td, endpoint);
mutex_unlock(&endpoint->lock);
@ -2241,8 +2243,8 @@ XHCI::HandleTransferComplete(xhci_trb* trb)
TRACE("HandleTransferComplete td %p done\n", td);
} else {
mutex_unlock(&endpoint->lock);
TRACE_ERROR("TRB %" B_PRIxADDR " was found, but it wasn't the "
"last in the TD!\n", source);
TRACE_ERROR("successful TRB %" B_PRIxADDR " was found, but it wasn't "
"the last in the TD!\n", source);
}
return;
}