Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

added a comment explaining why the implementation should be moved to the server

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27383 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stefano Ceccherini 2008-09-08 14:42:38 +00:00
parent 7e4c91ec88
commit 6ee56a00e5
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/kits/interface/View.cpp
View File

@ -61,8 +61,6 @@ using std::nothrow;
# define BVTRACE ; # define BVTRACE ;
#endif #endif
#define MAX_ATTACHMENT_SIZE 49152
static property_info sViewPropInfo[] = { static property_info sViewPropInfo[] = {
{ "Frame", { B_GET_PROPERTY, 0 }, { "Frame", { B_GET_PROPERTY, 0 },
@ -4400,7 +4398,10 @@ BView::_ClipToPicture(BPicture *picture, BPoint where,
#if 1 #if 1
// TODO: Move the implementation to the server!!! // TODO: Move the implementation to the server!!!
// This implementation is pretty slow, since just creating an offscreen bitmap
// takes a lot of time. That's the main reason why it should be moved
// to the server.
// Here the idea is to get rid of the padding bytes in the bitmap, // Here the idea is to get rid of the padding bytes in the bitmap,
// as padding complicates and slows down the iteration. // as padding complicates and slows down the iteration.
// TODO: Maybe it's not so nice as it assumes BBitmaps to be aligned // TODO: Maybe it's not so nice as it assumes BBitmaps to be aligned
@ -4433,7 +4434,7 @@ BView::_ClipToPicture(BPicture *picture, BPoint where,
for (int32 y = 0; y < height; y++) { for (int32 y = 0; y < height; y++) {
for (int32 x = 0; x < width; x++) { for (int32 x = 0; x < width; x++) {
bit = *bits++; bit = *bits++;
if (bit != (uint32)-1) { if (bit != 0xFFFFFFFF) {
rect.left = x; rect.left = x;
rect.right = rect.left; rect.right = rect.left;
rect.top = rect.bottom = y; rect.top = rect.bottom = y;