Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[pkgman] pkgman informs if package is already installed.

Browse Source 
While installing packages through pkgman, it will inform if specific
package is already installed. Fixes #12447 : [pkgman] inform if a
package is already installed.
Change-Id: I194bc849c42ba52a696a6cb52d87aebaff530f35
This commit is contained in:
Hrishi Hiraskar 2018-02-15 17:47:56 +05:30 committed by Jérôme Duval
parent 0bb9fd3868
commit 6dc1f7eb1e
1 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/bin/pkgman/command_install.cpp
View File

@ -8,6 +8,11 @@
#include <getopt.h>
#include <package/manager/Exceptions.h>
#include <ObjectList.h>
#include <package/solver/SolverPackage.h>
#include <package/solver/SolverPackageSpecifier.h>
#include <package/solver/SolverPackageSpecifierList.h>
#include <stdio.h>
#include <stdlib.h>
@ -21,6 +26,7 @@
using namespace BPackageKit;
using namespace BPackageKit::BPrivate;
using namespace BPackageKit::BManager::BPrivate;
static const char* const kShortUsage =
@ -102,7 +108,35 @@ InstallCommand::Execute(int argc, const char* const* argv)
// perform the installation
PackageManager packageManager(location, interactive);
packageManager.SetDebugLevel(fCommonOptions.DebugLevel());
packageManager.Install(packages, packageCount);
try {
packageManager.Install(packages, packageCount);
} catch (BNothingToDoException&) {
// Output already installed packages
BSolverPackageSpecifierList packagesToInstall;
if (!packagesToInstall.AppendSpecifiers(packages, packageCount))
throw std::bad_alloc();
// Find the installed packages that match the specification
const BSolverPackageSpecifier* unmatchedSpecifier;
BObjectList<BSolverPackage> installedPackages;
packageManager.Solver()->FindPackages(packagesToInstall,
BSolver::B_FIND_INSTALLED_ONLY,
installedPackages, &unmatchedSpecifier);
for (int32 i = 0; BSolverPackage* package = installedPackages.ItemAt(i);
i++) {
BString repository;
if (dynamic_cast<PackageManager::MiscLocalRepository*>(
package->Repository()) != NULL)
repository = "local file";
else
repository.SetToFormat(
"repository %s", package->Repository()->Name().String());
fprintf(stderr, "%s from %s is already installed.\n",
package->VersionedName().String(),
repository.String());
}
throw;
}
return 0;
}