Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kernel/x86: don't load microcode on intel when already up to date

Browse Source 
on Pentium Silver, loading the microcode on the boot cpu also updates the other ones.

Change-Id: Ifbd767e7d73fdbc8ae2bf0740fcce523e500de1b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6806
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
This commit is contained in:
Jérôme Duval 2023-08-10 17:26:46 +02:00 committed by Adrien Destugues
parent b761f9250a
commit 67ee1d1a3e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/system/kernel/arch/x86/arch_cpu.cpp
View File

@ -1095,7 +1095,9 @@ load_microcode_intel(int currentCPU, cpu_ent* cpu)
update = find_microcode_intel((addr_t)sUcodeData, sUcodeDataSize,
revision);
}
if (update != NULL) {
if (update == NULL) {
dprintf("CPU %d: no update found\n", currentCPU);
} else if (update->update_revision != revision) {
addr_t data = (addr_t)update + sizeof(struct intel_microcode_header);
wbinvd();
x86_write_msr(IA32_MSR_UCODE_WRITE, data);
@ -1105,11 +1107,9 @@ load_microcode_intel(int currentCPU, cpu_ent* cpu)
} else {
if (sLoadedUcodeUpdate == NULL)
sLoadedUcodeUpdate = update;
dprintf("CPU %d: updated from revision %" B_PRIu32 " to %" B_PRIu32
dprintf("CPU %d: updated from revision 0x%" B_PRIx32 " to 0x%" B_PRIx32
"\n", currentCPU, revision, cpu->arch.patch_level);
}
} else {
dprintf("CPU %d: no update found\n", currentCPU);
}
if (currentCPU != 0)
release_spinlock(&sUcodeUpdateLock);
@ -1451,7 +1451,7 @@ detect_cpu(int currentCPU, bool full = true)
dump_feature_string(currentCPU, cpu);
#endif
#if DUMP_CPU_PATCHLEVEL_TYPE
dprintf("CPU %d: patch_level %" B_PRIx32 "%s%s\n", currentCPU,
dprintf("CPU %d: patch_level 0x%" B_PRIx32 "%s%s\n", currentCPU,
cpu->arch.patch_level,
cpu->arch.hybrid_type != 0 ? ", hybrid type ": "",
get_hybrid_cpu_type_string(cpu->arch.hybrid_type));