Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CID 10361: Slight code simplification to remove superfluous for loop.

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40266 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Rene Gollent 2011-01-22 19:06:15 +00:00
parent ef83c28376
commit 67a473f7d5
1 changed files with 20 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
src/kits/tracker/StatusWindow.cpp
View File

@ -356,38 +356,29 @@ BStatusWindow::CheckCanceledOrPaused(thread_id thread)
BStatusView* view = NULL;
for (;;) {
AutoLock<BWindow> lock(this);
// check if cancel or pause hit
for (int32 index = fViewList.CountItems() - 1; index >= 0; index--) {
view = fViewList.ItemAt(index);
if (view && view->Thread() == thread) {
isPaused = view->IsPaused();
wasCanceled = view->WasCanceled();
break;
}
}
lock.Unlock();
if (wasCanceled || !isPaused)
AutoLock<BWindow> lock(this);
// check if cancel or pause hit
for (int32 index = fViewList.CountItems() - 1; index >= 0; index--) {
view = fViewList.ItemAt(index);
if (view && view->Thread() == thread) {
isPaused = view->IsPaused();
wasCanceled = view->WasCanceled();
break;
if (isPaused && view != NULL) {
AutoLock<BWindow> lock(this);
// say we are paused
view->Invalidate();
lock.Unlock();
ASSERT(find_thread(NULL) == view->Thread());
// and suspend ourselves
// we will get resumend from BStatusView::MessageReceived
suspend_thread(view->Thread());
}
break;
}
if (wasCanceled || !isPaused)
return wasCanceled;
if (isPaused && view != NULL) {
// say we are paused
view->Invalidate();
ASSERT(find_thread(NULL) == view->Thread());
// and suspend ourselves
// we will get resumed from BStatusView::MessageReceived
suspend_thread(view->Thread());
}
return wasCanceled;