Add webpositive package to image

build/jam/HaikuPackages

@@ -16,6 +16,7 @@ if $(HAIKU_BOOTSTRAP_BUILD) {
 
 local archDependentPackages =
 	HaikuCrossDevel
+	WebPositive
 	;
 
 local secondaryArchPackages =

build/jam/OptionalPackages

@@ -16,7 +16,6 @@
 #	NetFS					- the native networked file system components
 #	UserlandFS				- aids native file system development (like FUSE)
 #	WebPositive				- native, WebKit-based web browser
-#	WebPositiveBookmarks	- bookmarks for WebPositive
 #	Welcome					- introductory documentation to Haiku
 #	WifiFirmwareScriptData	- data files needed by install-wifi-firmwares.sh
 
@@ -26,7 +25,6 @@ OptionalPackageDependencies Development : DevelopmentBase ;
 OptionalPackageDependencies DevelopmentBase : DevelopmentMin ;
 OptionalPackageDependencies DevelopmentPowerPC : DevelopmentMin ;
 OptionalPackageDependencies NetFS : UserlandFS ;
-OptionalPackageDependencies WebPositive : WebPositiveBookmarks ;
 
 
 local baseURL = http://haiku-files.org/files/optional-packages ;
@@ -256,30 +254,18 @@ if [ IsOptionalHaikuImagePackageAdded UserlandFS ] {
 
 # WebPositive
 if [ IsOptionalHaikuImagePackageAdded WebPositive ] {
-# TODO: Make this an actual package!
+	local architectureObject ;
-# 	if $(TARGET_ARCH) != x86  && $(TARGET_ARCH) != x86_64 {
+	for architectureObject in [ MultiArchSubDirSetup ] {
-# 		Echo "No optional package WebPositive available for $(TARGET_ARCH)" ;
+		on $(architectureObject) {
-# 	} else if $(TARGET_GCC_VERSION_$(TARGET_PACKAGING_ARCH)[1]) < 4 {
+			if [ FIsBuildFeatureEnabled webpositive ] {
-# 		Echo "No optional package WebPositive available for gcc2" ;
+				AddPackageFilesToHaikuImage system : webpositive.hpkg ;
-# 	} else if $(TARGET_GCC_VERSION_$(TARGET_PACKAGING_ARCH)[1]) >= 4 {
+				InstallOptionalHaikuImagePackage
-# 		# TODO: Either we build a separate package for WebPositive or we
+					$(baseURL)/WebPositiveBookmarks-2012-02-18.zip
-# 		# incorporate it in haiku.hpkg.
+					: home config settings WebPositive ;
-# 		AddFilesToHaikuHybridImage apps : WebPositive ;
+				break ;
-# 		AddSymlinkToHaikuHybridImage
+			}
-# 			home config settings deskbar menu Applications
+		}
-# 			: /boot/common/apps/WebPositive ;
+	}
-# 	}
-#
-# AddHaikuImagePackages curl libxml2 sqlite webkit ;
-	# TODO: Should be properly declared requires in the webpositive package.
-}
-
-
-# WebPositiveBookmarks
-if [ IsOptionalHaikuImagePackageAdded WebPositiveBookmarks ] {
-	InstallOptionalHaikuImagePackage
-		$(baseURL)/WebPositiveBookmarks-2012-02-18.zip
-		: home config settings WebPositive ;
 }
 
 

build/jam/packages/WebPositive

@@ -0,0 +1,11 @@
+if [ FIsBuildFeatureEnabled webpositive ] {
+	local architecture = $(TARGET_PACKAGING_ARCH) ;
+	local webpositivePackage = webpositive.hpkg ;
+	HaikuPackage $(webpositivePackage) ;
+
+	AddFilesToPackage apps : WebPositive ;
+	AddSymlinkToPackage data deskbar menu Applications
+		: ../../../../apps/WebPositive : WebPositive ;
+
+	BuildHaikuPackage $(webpositivePackage) : webpositive ;
+}

src/apps/webpositive/Jamfile

@@ -1,7 +1,5 @@
 SubDir HAIKU_TOP src apps webpositive ;
 
-SubDirSysHdrs $(HAIKU_WEBKIT_HEADERS) ;
-
 SubDirC++Flags $(defines) -Wno-error=sequence-point ;
 SubDirCcFlags $(defines) -Wno-error=sequence-point ;
 
@@ -12,11 +10,6 @@ local sourceDirs =
 	tabview
 ;
 
-local sourceDir ;
-for sourceDir in $(sourceDirs) {
-	SEARCH_SOURCE += [ FDirName $(HAIKU_TOP) src apps webpositive $(sourceDir) ] ;
-}
-
 local sources =
 	# autocompletion
 	AutoCompleter.cpp
@@ -46,28 +39,52 @@ local sources =
 	URLInputGroup.cpp
 ;
 
-Includes [ FGristFiles $(sources) ] : $(HAIKU_WEBKIT_HEADERS_DEPENDENCY) ;
+# We build WebPositive only for one architecture -- the first architecture for
-	# Dependency needed to trigger downloading/unzipping the package before
+# which it is possible.
-	# compiling the files.
+local architectureObject ;
+for architectureObject in [ MultiArchSubDirSetup ] {
+	on $(architectureObject) {
+		if ! [ FIsBuildFeatureEnabled webkit ] {
+			continue ;
+		}
 
-# private OS headers
+		UseBuildFeatureHeaders webkit ;
-UseLibraryHeaders icon ;
-UsePrivateHeaders shared tracker ;
-SubDirHdrs $(HAIKU_TOP) src kits tracker ;
 
+		local sourceDir ;
+		for sourceDir in $(sourceDirs) {
+			SEARCH_SOURCE
+				+= [ FDirName $(HAIKU_TOP) src apps webpositive $(sourceDir) ] ;
+		}
 
-Application WebPositive :
+		Includes [ FGristFiles $(sources) ]
-	$(sources)
+			: [ BuildFeatureAttribute webkit : headers ] ;
-	:
+			# Dependency needed to trigger downloading/unzipping the package
-	$(HAIKU_WEBKIT_LIBS)
+			# before compiling the files.
-	$(TARGET_LIBSTDC++) localestub
-	be libshared.a network tracker translation
-	:
-	WebPositive.rdef
-;
 
-DoCatalogs WebPositive :
+		# private OS headers
-	x-vnd.Haiku-WebPositive
+		UseLibraryHeaders icon ;
-	:
+		UsePrivateHeaders shared tracker ;
-	$(sources)
+		SubDirHdrs $(HAIKU_TOP) src kits tracker ;
-;
+
+		Application WebPositive :
+			$(sources)
+			:
+			[ BuildFeatureAttribute webkit : libraries ]
+			$(TARGET_LIBSTDC++) localestub
+			[ MultiArchDefaultGristFiles libshared.a ]
+			be network tracker translation
+			:
+			WebPositive.rdef
+			;
+
+		DoCatalogs WebPositive :
+			x-vnd.Haiku-WebPositive
+			:
+			$(sources)
+			;
+
+		EnableBuildFeatures webpositive ;
+
+		break ;
+	}
+}

src/data/package_infos/generic/webpositive

@@ -0,0 +1,20 @@
+name			webpositive%HAIKU_SECONDARY_PACKAGING_ARCH_SUFFIX%
+version			R1~alpha4_pm-1
+architecture	HAIKU_PACKAGING_ARCH
+summary			"A WebKit based web browser for Haiku"
+
+description		"A WebKit based web browser for Haiku."
+
+packager		"The Haiku build system"
+vendor			"Haiku Project"
+
+copyrights		"2001-2013 Haiku, Inc. et al"
+licenses		"MIT"
+
+provides {
+	webpositive%HAIKU_SECONDARY_PACKAGING_ARCH_SUFFIX% = R1~alpha4_pm-1
+}
+
+requires {
+	haikuwebkit%HAIKU_SECONDARY_PACKAGING_ARCH_SUFFIX%
+}