Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

XHCI: Remove logically dead code.

Browse Source 
This is inside a "endpointId > 0" block, and endpointNum=id+1,
so we will never call EvaluateContext here. (Endpoint "1" is
configured by AllocateDevice.)

Spotted by Coverity.
This commit is contained in:
Augustin Cavalier 2020-03-01 16:19:03 -05:00
parent dda8e77b8e
commit 51d0d6e229
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/add-ons/kernel/busses/usb/xhci.cpp
View File

@ -1737,10 +1737,7 @@ XHCI::_InsertEndpointForPipe(Pipe *pipe)
_WriteContext(&device->input_ctx->input.addFlags,
(1 << endpointNum) | (1 << 0));
if (endpointNum > 1)
ConfigureEndpoint(device->input_ctx_addr, false, device->slot);
else
EvaluateContext(device->input_ctx_addr, device->slot);
ConfigureEndpoint(device->input_ctx_addr, false, device->slot);
TRACE("device: address 0x%x state 0x%08" B_PRIx32 "\n",
device->address, SLOT_3_SLOT_STATE_GET(_ReadContext(