Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

generic/tty: Add an assertion and a comment about references.

Browse Source 
No functional change.
This commit is contained in:
Augustin Cavalier 2023-07-11 11:31:26 -04:00
parent 5193c8cd2f
commit 4b02e067a6
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/add-ons/kernel/generic/tty/tty.cpp
View File

@ -1381,6 +1381,8 @@ void
tty_destroy(struct tty* tty) tty_destroy(struct tty* tty)
{ {
TRACE(("tty_destroy(%p)\n", tty)); TRACE(("tty_destroy(%p)\n", tty));
ASSERT(tty->ref_count == 0);
uninit_line_buffer(tty->input_buffer); uninit_line_buffer(tty->input_buffer);
delete_select_sync_pool(tty->select_pool); delete_select_sync_pool(tty->select_pool);
if (tty->is_master) { if (tty->is_master) {
@ -1756,6 +1758,10 @@ tty_control(tty_cookie* cookie, uint32 op, void* buffer, size_t length)
tty->settings->session_id = sessionID; tty->settings->session_id = sessionID;
tty->settings->pgrp_id = sessionID; tty->settings->pgrp_id = sessionID;
team_set_controlling_tty(tty); team_set_controlling_tty(tty);
// NOTE: We do not acquire a reference to the TTY for the team, so
// consumers of team_get_controlling_tty() must check the TTY is still
// valid before actually using it!
return B_OK; return B_OK;
} }