From 4a3dae2baceddd33d733666aecc907c7cc318be6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Revol?= Date: Mon, 8 Oct 2018 00:56:11 +0200 Subject: [PATCH] package kit: add a NULL check on requests This avoid crashing on malformed repository URL (like missing http://). --- src/kits/package/FetchFileJob.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/kits/package/FetchFileJob.cpp b/src/kits/package/FetchFileJob.cpp index 2ec38fcb04..6f53ca8647 100644 --- a/src/kits/package/FetchFileJob.cpp +++ b/src/kits/package/FetchFileJob.cpp @@ -90,6 +90,9 @@ FetchFileJob::Execute() BUrlRequest* request = BUrlProtocolRoster::MakeRequest(fFileURL.String(), this); + if (request == NULL) + return B_BAD_VALUE; + thread_id thread = request->Run(); wait_for_thread(thread, NULL);