From 476d0ad38e6fb3efc33d6548ef2fe7f3cd705159 Mon Sep 17 00:00:00 2001 From: Zotyamester Date: Thu, 9 Jan 2020 20:34:10 +0000 Subject: [PATCH] Terminal: Minor fixes Change-Id: I10d1a248e62f37a34c1d2d0ae3088403c6de3adf Reviewed-on: https://review.haiku-os.org/c/haiku/+/2094 Reviewed-by: waddlesplash --- src/apps/terminal/TermApp.cpp | 3 +-- src/apps/terminal/TermView.cpp | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/apps/terminal/TermApp.cpp b/src/apps/terminal/TermApp.cpp index ff1328c672..a27c57a2df 100644 --- a/src/apps/terminal/TermApp.cpp +++ b/src/apps/terminal/TermApp.cpp @@ -125,14 +125,13 @@ TermApp::ReadyToRun() status_t status = _MakeTermWindow(); // failed spawn, print stdout and open alert panel - // TODO: This alert does never show up. if (status < B_OK) { BAlert* alert = new BAlert("alert", B_TRANSLATE("Terminal couldn't start the shell. Sorry."), B_TRANSLATE("OK"), NULL, NULL, B_WIDTH_FROM_LABEL, B_INFO_ALERT); alert->SetFlags(alert->Flags() | B_CLOSE_ON_ESCAPE); - alert->Go(NULL); + alert->Go(); PostMessage(B_QUIT_REQUESTED); return; } diff --git a/src/apps/terminal/TermView.cpp b/src/apps/terminal/TermView.cpp index 3c2232f880..22f3c81830 100644 --- a/src/apps/terminal/TermView.cpp +++ b/src/apps/terminal/TermView.cpp @@ -3022,8 +3022,6 @@ TermView::_HandleInputMethodChanged(BMessage *message) KeyDown(prevPos, currPos - prevPos); prevPos = currPos; } - - Invalidate(); } else { // temporarily show transient state of inline input int32 selectionStart = 0; @@ -3033,8 +3031,8 @@ TermView::_HandleInputMethodChanged(BMessage *message) fInline->SetSelectionOffset(selectionStart); fInline->SetSelectionLength(selectionEnd - selectionStart); - Invalidate(); } + Invalidate(); }