Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BeDecorator Draw outer left close button bevel to the edge

Browse Source 
... just like BeOS R5 did.

In 3123432674 (hrev52122) I wrote:

"Undraw the bottom left and top right corners of bitmaps in the
unpressed state. BeOS did not do this (usually), but it should
have as it closes the ring."

This was a bad idea, draw like BeOS R5 instead.

Change-Id: I4eba7566bb31d3e208bc30439b0221b70eeb2bbe
Reviewed-on: https://review.haiku-os.org/c/1066
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
This commit is contained in:
John Scipione 2019-02-18 20:50:07 -08:00 committed by waddlesplash
parent e680a439bf
commit 4512141632
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/add-ons/decorators/BeDecorator/BeDecorator.cpp
View File

@ -981,14 +981,6 @@ BeDecorator::_GetBitmapForButton(Decorator::Tab* tab, Component item,
_DrawBevelRect(sBitmapDrawingEngine, rect, tab->closePressed,
buttonColorLight2, buttonColorShadow2);
if (!tab->closePressed) {
// undraw bottom left and top right corners
sBitmapDrawingEngine->StrokePoint(rect.LeftBottom(),
buttonColor);
sBitmapDrawingEngine->StrokePoint(rect.RightTop(),
buttonColor);
}
if (fCStatus != B_OK) {
// If we ran out of memory while initializing bitmaps
// fall back to a linear gradient.
@ -1148,14 +1140,6 @@ BeDecorator::_GetBitmapForButton(Decorator::Tab* tab, Component item,
_DrawBevelRect(sBitmapDrawingEngine, bigRect, tab->zoomPressed,
buttonColorLight2, buttonColorShadow2);
if (!tab->zoomPressed) {
// undraw bottom left and top right corners
sBitmapDrawingEngine->StrokePoint(bigRect.LeftBottom(),
buttonColor);
sBitmapDrawingEngine->StrokePoint(bigRect.RightTop(),
buttonColor);
}
if (fCStatus != B_OK) {
// If we ran out of memory while initializing bitmaps
// fall back to a linear gradient.