From 451214163224e75d3ec07cbb1d1e9d59fad2ca11 Mon Sep 17 00:00:00 2001 From: John Scipione Date: Mon, 18 Feb 2019 20:50:07 -0800 Subject: [PATCH] BeDecorator Draw outer left close button bevel to the edge ... just like BeOS R5 did. In 31234326741231bb8d36456ce9dbdccec7ce0e3b (hrev52122) I wrote: "Undraw the bottom left and top right corners of bitmaps in the unpressed state. BeOS did not do this (usually), but it should have as it closes the ring." This was a bad idea, draw like BeOS R5 instead. Change-Id: I4eba7566bb31d3e208bc30439b0221b70eeb2bbe Reviewed-on: https://review.haiku-os.org/c/1066 Reviewed-by: Adrien Destugues --- .../decorators/BeDecorator/BeDecorator.cpp | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/add-ons/decorators/BeDecorator/BeDecorator.cpp b/src/add-ons/decorators/BeDecorator/BeDecorator.cpp index 3d299e82e1..c6fcfd48ce 100644 --- a/src/add-ons/decorators/BeDecorator/BeDecorator.cpp +++ b/src/add-ons/decorators/BeDecorator/BeDecorator.cpp @@ -981,14 +981,6 @@ BeDecorator::_GetBitmapForButton(Decorator::Tab* tab, Component item, _DrawBevelRect(sBitmapDrawingEngine, rect, tab->closePressed, buttonColorLight2, buttonColorShadow2); - if (!tab->closePressed) { - // undraw bottom left and top right corners - sBitmapDrawingEngine->StrokePoint(rect.LeftBottom(), - buttonColor); - sBitmapDrawingEngine->StrokePoint(rect.RightTop(), - buttonColor); - } - if (fCStatus != B_OK) { // If we ran out of memory while initializing bitmaps // fall back to a linear gradient. @@ -1148,14 +1140,6 @@ BeDecorator::_GetBitmapForButton(Decorator::Tab* tab, Component item, _DrawBevelRect(sBitmapDrawingEngine, bigRect, tab->zoomPressed, buttonColorLight2, buttonColorShadow2); - if (!tab->zoomPressed) { - // undraw bottom left and top right corners - sBitmapDrawingEngine->StrokePoint(bigRect.LeftBottom(), - buttonColor); - sBitmapDrawingEngine->StrokePoint(bigRect.RightTop(), - buttonColor); - } - if (fCStatus != B_OK) { // If we ran out of memory while initializing bitmaps // fall back to a linear gradient.