Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compat/freebsd_network: Fix dead store

Browse Source 
Fix value stored to 'newPowerManagementStatus' is never read.
Pointed out by Clang Static Analyzer.

It seems FreeBSD's pci_set_powerstate_method() writes 'status'
(newPowerManagementStatus in Haiku) with PCI_WRITE_CONFIG
(pci_write_config in Haiku).

Change-Id: I9b11f746ed8e772a3f839e1bd5a6b432c9e8ff6b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3513
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
This commit is contained in:
Murai Takashi 2020-12-16 06:18:46 +09:00 committed by waddlesplash
parent 7dec2bff46
commit 44e4aca7cc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/compat/freebsd_network/bus.cpp
View File

@ -1002,8 +1002,8 @@ pci_set_powerstate(device_t dev, int newPowerState)
}
TRACE_PCI(dev, "%s: D%i -> D%i\n", __func__, oldPowerState, newPowerState);
pci_write_config(dev, capabilityRegister + PCIR_POWER_STATUS, newPowerState,
2);
pci_write_config(dev, capabilityRegister + PCIR_POWER_STATUS,
newPowerManagementStatus, 2);
if (stateTransitionDelayInUs != 0)
snooze(stateTransitionDelayInUs);