From 3d01d427aea8c849257197f23564aca7030bf606 Mon Sep 17 00:00:00 2001
From: Adrien Destugues <pulkomandy@gmail.com>
Date: Wed, 26 Nov 2014 10:35:43 +0100
Subject: [PATCH] Keymap preferneces: improve deadkey handling logic

* The key down message is not delivered when completing a dead key, so
act on key up instead.
* Pressing a character after a dead key would leave the keymap in "dead
key" mode, and that mode would be exited only by pressing a dead key
again.

Fixes #5734.
---
 src/preferences/keymap/KeyboardLayoutView.cpp | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/preferences/keymap/KeyboardLayoutView.cpp b/src/preferences/keymap/KeyboardLayoutView.cpp
index 64f2a58814..7586bcf25d 100644
--- a/src/preferences/keymap/KeyboardLayoutView.cpp
+++ b/src/preferences/keymap/KeyboardLayoutView.cpp
@@ -1164,15 +1164,13 @@ KeyboardLayoutView::_HandleDeadKey(uint32 key, int32 modifiers)
 
 	bool isEnabled = false;
 	int32 deadKey = fKeymap->DeadKey(key, modifiers, &isEnabled);
-	if (fDeadKey != deadKey) {
-		if (isEnabled) {
-			Invalidate();
-			fDeadKey = deadKey;
-			return true;
-		}
-	} else if (fDeadKey != 0) {
+	if (fDeadKey != deadKey && isEnabled) {
+		fDeadKey = deadKey;
 		Invalidate();
+		return true;
+	} else if (fDeadKey != 0) {
 		fDeadKey = 0;
+		Invalidate();
 		return true;
 	}
 
@@ -1196,7 +1194,7 @@ KeyboardLayoutView::_KeyChanged(const BMessage* message)
 
 	bool checkSingle = true;
 
-	if (message->what == B_KEY_DOWN || message->what == B_UNMAPPED_KEY_DOWN) {
+	if (message->what == B_KEY_UP || message->what == B_UNMAPPED_KEY_UP) {
 		if (_HandleDeadKey(key, fModifiers))
 			checkSingle = false;