Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AbstractSpinner: fix calling base class virtual methods (untested)

Browse Source 
AbstractSpinner inherits from BControl, so it should call BControl's virtual methods, not BView's.
Found by Andrea Anzani

Change-Id: If4c921d91a5095769d5f2da1832ad5bf4533becc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7066
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
This commit is contained in:
JackBurton79 2023-10-25 00:19:41 +02:00 committed by Adrien Destugues
parent 538f9a182c
commit 3c3462995f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/kits/interface/AbstractSpinner.cpp
View File

@ -968,7 +968,7 @@ BAbstractSpinner::GetSupportedSuites(BMessage* message)
BPropertyInfo prop_info(sProperties); BPropertyInfo prop_info(sProperties);
message->AddFlat("messages", &prop_info); message->AddFlat("messages", &prop_info);
return BView::GetSupportedSuites(message); return BControl::GetSupportedSuites(message);
} }
@ -976,7 +976,7 @@ BHandler*
BAbstractSpinner::ResolveSpecifier(BMessage* message, int32 index, BMessage* specifier, BAbstractSpinner::ResolveSpecifier(BMessage* message, int32 index, BMessage* specifier,
int32 form, const char* property) int32 form, const char* property)
{ {
return BView::ResolveSpecifier(message, index, specifier, form, return BControl::ResolveSpecifier(message, index, specifier, form,
property); property);
} }
@ -993,7 +993,7 @@ BAbstractSpinner::AttachedToWindow()
_UpdateTextViewColors(IsEnabled()); _UpdateTextViewColors(IsEnabled());
fTextView->MakeEditable(IsEnabled()); fTextView->MakeEditable(IsEnabled());
BView::AttachedToWindow(); BControl::AttachedToWindow();
} }
@ -1010,7 +1010,7 @@ BAbstractSpinner::Draw(BRect updateRect)
void void
BAbstractSpinner::FrameResized(float width, float height) BAbstractSpinner::FrameResized(float width, float height)
{ {
BView::FrameResized(width, height); BControl::FrameResized(width, height);
// TODO: this causes flickering still... // TODO: this causes flickering still...
@ -1086,7 +1086,7 @@ BAbstractSpinner::MakeFocus(bool focus)
void void
BAbstractSpinner::ResizeToPreferred() BAbstractSpinner::ResizeToPreferred()
{ {
BView::ResizeToPreferred(); BControl::ResizeToPreferred();
const char* label = Label(); const char* label = Label();
if (label != NULL) { if (label != NULL) {
@ -1115,7 +1115,7 @@ BAbstractSpinner::SetFlags(uint32 flags)
// Don't make this one navigable // Don't make this one navigable
flags &= ~B_NAVIGABLE; flags &= ~B_NAVIGABLE;
BView::SetFlags(flags); BControl::SetFlags(flags);
} }