From 382fff8961085bcf00e2615bf77ebcab8b4f4aa0 Mon Sep 17 00:00:00 2001 From: Augustin Cavalier Date: Fri, 23 Nov 2018 19:14:49 -0500 Subject: [PATCH] ArchitectureRules: Enable -Wuninitialized and -Wunused-but-set. Also clean up the warning flags in general; they are now more readable. --- build/jam/ArchitectureRules | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/build/jam/ArchitectureRules b/build/jam/ArchitectureRules index 7ac2276521..0dcf1cb8ee 100644 --- a/build/jam/ArchitectureRules +++ b/build/jam/ArchitectureRules @@ -118,12 +118,15 @@ rule ArchitectureSetup architecture } # warning flags - HAIKU_WARNING_CCFLAGS_$(architecture) - = -Wall -Wno-trigraphs -Wmissing-prototypes - -Wpointer-arith -Wcast-align -Wsign-compare -Wno-multichar ; - HAIKU_WARNING_C++FLAGS_$(architecture) = -Wall -Wno-trigraphs - -Wno-ctor-dtor-privacy -Woverloaded-virtual -Wpointer-arith -Wcast-align - -Wsign-compare -Wno-multichar ; + HAIKU_WARNING_CCFLAGS_$(architecture) = -Wall + -Wno-trigraphs -Wno-unused-parameter -Wno-multichar + -Wpointer-arith -Wcast-align -Wsign-compare + -Wmissing-prototypes ; + HAIKU_WARNING_C++FLAGS_$(architecture) = -Wall + -Wno-trigraphs -Wno-unused-parameter -Wno-multichar + -Wpointer-arith -Wcast-align -Wsign-compare + -Wno-ctor-dtor-privacy -Woverloaded-virtual ; + # disable some Clang warnings that are not very useful if $(HAIKU_CC_IS_CLANG_$(architecture)) = 1 { HAIKU_WARNING_CCFLAGS_$(architecture) += -Wno-address-of-packed-member @@ -135,12 +138,8 @@ rule ArchitectureSetup architecture HAIKU_WERROR_FLAGS_$(architecture) = ; if $(gccVersion[1]) >= 4 { - # -Wuninitialized gives too many false positives. - HAIKU_WERROR_FLAGS_$(architecture) += -Wno-error=uninitialized - -Wno-error=maybe-uninitialized ; - # TODO: remove the -Wno-unused-but-set-variable option - HAIKU_WERROR_FLAGS_$(architecture) += -Wno-unused-but-set-variable ; + HAIKU_WERROR_FLAGS_$(architecture) += -Wno-error=unused-but-set-variable ; } # debug flags