Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libtracker: don't try to fix permissions on read-only volumes

Browse Source 
* instead try to guess the type, find the app, and launch the app with the document refs.
* fix #5783

Change-Id: Icd25a81ff28038fec0494045390edc6271433b07
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5425
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
This commit is contained in:
Jérôme Duval 2022-06-30 17:28:42 +02:00 committed by waddlesplash
parent 3571cd8a6b
commit 374a3a07a1
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/kits/tracker/FSUtils.cpp
View File

@ -2463,7 +2463,7 @@ FSRecursiveCalcSize(BInfoWindow* window, CopyLoopControl* loopControl,
if (status != B_OK)
return status;
(*_runningSize) += statbuf.st_blocks* 512;
(*_runningSize) += statbuf.st_blocks * 512;
if (S_ISDIR(statbuf.st_mode)) {
BDirectory subdir(&entry);
@ -3583,6 +3583,24 @@ _TrackerLaunchDocuments(const entry_ref*, const BMessage* refs,
error = B_OK;
if (error == B_OK || mimesetIt != 0)
break;
if (error == B_LAUNCH_FAILED_EXECUTABLE) {
BVolume volume(documentRef.device);
if (volume.IsReadOnly()) {
BMimeType type;
error = BMimeType::GuessMimeType(&documentRef, &type);
if (error != B_OK)
break;
error = be_roster->FindApp(type.Type(), &app);
if (error != B_OK)
break;
error = be_roster->Launch(&app, refs, &team);
if (error == B_ALREADY_RUNNING)
// app already running, not really an error
error = B_OK;
if (error == B_OK || mimesetIt != 0)
break;
}
}
SniffIfGeneric(&copyOfRefs);
}