Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

app_server: match screen configurations with empty serial number

Browse Source 
My laptop LCD has no serial number. Because of this check, it would
never "exact match" with the previous data stored in the workspace
settings. As a result, every time I set a new video mode, a new "screen"
would be stored in the settings file, and the old entry would just stay
there and never be used again.

I currently find myself with about 100K of workspace settings, tracing
the history of video mode changes over the last few years.

Change-Id: Iea236a6ad09bc8bae9f6df8d63780bbfd4fa5619
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2135
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
This commit is contained in:
Adrien Destugues 2020-01-20 21:51:17 +01:00 committed by waddlesplash
parent 8d763b7f0d
commit 35e9e7c3eb
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/servers/app/ScreenConfigurations.cpp
View File

@ -76,9 +76,8 @@ ScreenConfigurations::BestFit(int32 id, const monitor_info* info,
&& !strcasecmp(configuration->info.name, info->name)
&& configuration->info.product_id == info->product_id) {
score += 2;
if (info->serial_number[0] != '\0'
&& !strcmp(configuration->info.serial_number,
info->serial_number)) {
if (strcmp(configuration->info.serial_number,
info->serial_number) == 0) {
exactMatch = true;
score += 2;
}