Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* B_AVOID_FOCUS windows never got mouse clicks. This fixes bug #1652.

Browse Source 
* Our behaviour differs a bit from how BeOS handles those windows, added a
  comment to the code which explains that, and how we could change it if we
  really wanted to.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23705 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler 2008-01-22 19:08:28 +00:00
parent ea0331c6f9
commit 2d0687ae9e
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/servers/app/WindowLayer.cpp
View File

@ -820,6 +820,7 @@ WindowLayer::MouseDown(BMessage* message, BPoint where, int32* _viewToken)
} }
} }
} else { } else {
// click was inside the window contents
if (ViewLayer* view = ViewAt(where)) { if (ViewLayer* view = ViewAt(where)) {
if (HasModal()) if (HasModal())
return; return;
@ -834,9 +835,14 @@ WindowLayer::MouseDown(BMessage* message, BPoint where, int32* _viewToken)
&& desktopSettings.MouseMode() == B_NORMAL_MOUSE) && desktopSettings.MouseMode() == B_NORMAL_MOUSE)
fDesktop->ActivateWindow(this); fDesktop->ActivateWindow(this);
// eat the click if we don't accept first click // Eat the click if we don't accept first click
if ((Flags() & B_WILL_ACCEPT_FIRST_CLICK) == 0 // (B_AVOID_FOCUS never gets the focus, so they always accept
|| (Flags() & B_AVOID_FOCUS) != 0) // the first click)
// TODO: the latter is unlike BeOS - if we really wanted to
// imitate this behaviour, we would need to check if we're
// the front window instead of the focus window
if ((Flags() & (B_WILL_ACCEPT_FIRST_CLICK
| B_AVOID_FOCUS)) == 0)
return; return;
} }