Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable and fix WError in add-ons/kernel/busses/

Browse Source 
Change-Id: I94e1580444faffdfc362dc8f59c39152d67a7076
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5235
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
This commit is contained in:
PulkoMandy 2022-04-22 18:39:05 +02:00 committed by Adrien Destugues
parent ad398477d6
commit 1da90c98f2
4 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
build/jam/ArchitectureRules
View File

@ -665,14 +665,7 @@ rule ArchitectureSetupWarnings architecture
EnableWerror src add-ons input_server ; EnableWerror src add-ons input_server ;
EnableWerror src add-ons kernel bluetooth ; EnableWerror src add-ons kernel bluetooth ;
EnableWerror src add-ons kernel bus_managers ; EnableWerror src add-ons kernel bus_managers ;
EnableWerror src add-ons kernel busses agp_gart ; EnableWerror src add-ons kernel busses ;
EnableWerror src add-ons kernel busses ata ;
# EnableWerror src add-ons kernel busses i2c ;
# EnableWerror src add-ons kernel busses mmc ;
# EnableWerror src add-ons kernel busses random ;
EnableWerror src add-ons kernel busses scsi ;
EnableWerror src add-ons kernel busses usb ;
# EnableWerror src add-ons kernel busses virtio ;
EnableWerror src add-ons kernel console ; EnableWerror src add-ons kernel console ;
EnableWerror src add-ons kernel cpu ; EnableWerror src add-ons kernel cpu ;
EnableWerror src add-ons kernel debugger ; EnableWerror src add-ons kernel debugger ;

1
src/add-ons/kernel/busses/i2c/pch_i2c.cpp
View File

@ -345,7 +345,6 @@ pch_i2c_scan_bus_callback(acpi_handle object, uint32 nestingLevel,
return status; return status;
} }
device_node* deviceNode;
status = gI2c->register_device(bus->sim, crs.i2c_addr, hid, cidList, status = gI2c->register_device(bus->sim, crs.i2c_addr, hid, cidList,
object); object);
free(hid); free(hid);

6
src/add-ons/kernel/busses/i2c/pch_i2c_pci.cpp
View File

@ -389,11 +389,13 @@ supports_device(device_node* parent)
pci_device* device; pci_device* device;
gDeviceManager->get_driver(parent, (driver_module_info**)&pci, gDeviceManager->get_driver(parent, (driver_module_info**)&pci,
(void**)&device); (void**)&device);
#ifdef TRACE_PCH_I2C
uint8 pciSubDeviceId = pci->read_pci_config(device, PCI_revision, uint8 pciSubDeviceId = pci->read_pci_config(device, PCI_revision,
1); 1);
TRACE("PCH I2C device found! vendor 0x%04x, device 0x%04x\n", vendorID, TRACE("PCH I2C device found! vendor 0x%04x, device 0x%04x, subdevice 0x%02x\n", vendorID,
deviceID); deviceID, pciSubDeviceId);
#endif
return 0.8f; return 0.8f;
} }

2
src/add-ons/kernel/busses/mmc/sdhci_pci.h
View File

@ -210,7 +210,7 @@ class Capabilities
static const uint8_t k1v8 = 4; static const uint8_t k1v8 = 4;
private: private:
const uint64_t fBits; uint64_t fBits;
} __attribute__((packed)); } __attribute__((packed));