Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bindfs: Keep settings in scope for the entire Mount operation

Browse Source 
Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

* Fixes #11760.
* Bug made visible by the changes to fix private driver settings. Before
the change, the settings were most often leaked, so there was no
use-after-free.
This commit is contained in:
Puck Meerburg 2015-01-16 20:42:15 +01:00 committed by Adrien Destugues
parent 19ce061e0b
commit 14d1920039
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/add-ons/kernel/file_systems/bindfs/Volume.cpp
View File

@ -51,10 +51,10 @@ Volume::Mount(const char* parameterString)
{
const char* source = NULL;
void* parameterHandle = parse_driver_settings_string(parameterString);
if (parameterHandle != NULL) {
CObjectDeleter<void, status_t> parameterDeleter(parameterHandle,
delete_driver_settings);
if (parameterHandle != NULL)
source = get_driver_parameter(parameterHandle, "source", NULL, NULL);
delete_driver_settings(parameterHandle);
}
if (source == NULL || source[0] == '\0') {
ERROR("need source folder ('source' parameter)!\n");
RETURN_ERROR(B_BAD_VALUE);