From 1446507ce3ff2f1cb1f2b24df6fcc55e10c937a8 Mon Sep 17 00:00:00 2001 From: Fredrik Holmqvist Date: Sun, 31 Dec 2017 17:23:25 +0100 Subject: [PATCH] Remove the code to force ACPI to shutdown on CPU0 It was discussed and introduced based on docs that some systems need this to shutdown properly. I can find no mention of this in ACPICA or ACPI docs. This needs to be re-evalutad, as all my shutdowns been successful after disabling it and I can't locate where this info came from or if it actually helped. See 1316462ab0fd0f25f7dbb7f23b607d981efd3edc for original commit and bug 12306 on current shutdown issue. --- src/system/kernel/arch/x86/arch_cpu.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/system/kernel/arch/x86/arch_cpu.cpp b/src/system/kernel/arch/x86/arch_cpu.cpp index 65ea7fce1c..930144d57b 100644 --- a/src/system/kernel/arch/x86/arch_cpu.cpp +++ b/src/system/kernel/arch/x86/arch_cpu.cpp @@ -122,15 +122,6 @@ acpi_shutdown(bool rebootSystem) if (rebootSystem) { status = acpi->reboot(); } else { - // Make sure we run on the boot CPU (apparently needed for some ACPI - // implementations) - _user_set_cpu_enabled(0, true); - for (int32 cpu = 1; cpu < smp_get_num_cpus(); cpu++) { - _user_set_cpu_enabled(cpu, false); - } - // TODO: must not be called from the idle thread! - thread_yield(); - status = acpi->prepare_sleep_state(ACPI_POWER_STATE_OFF, NULL, 0); if (status == B_OK) { //cpu_status state = disable_interrupts();