From 122abe4315025e31dbcb414cef0976247699f84f Mon Sep 17 00:00:00 2001
From: John Scipione <jscipione@gmail.com>
Date: Mon, 9 Jun 2014 15:41:36 -0400
Subject: [PATCH] Expander: Check Window()->Lock() return value

---
 src/apps/expander/DirectoryFilePanel.cpp | 47 ++++++++++++------------
 1 file changed, 24 insertions(+), 23 deletions(-)

diff --git a/src/apps/expander/DirectoryFilePanel.cpp b/src/apps/expander/DirectoryFilePanel.cpp
index 1b87b030bc..cc2b91d4af 100644
--- a/src/apps/expander/DirectoryFilePanel.cpp
+++ b/src/apps/expander/DirectoryFilePanel.cpp
@@ -64,8 +64,7 @@ DirectoryFilePanel::DirectoryFilePanel(file_panel_mode mode,
 void
 DirectoryFilePanel::Show()
 {
-	if (fCurrentButton == NULL) {
-		Window()->Lock();
+	if (fCurrentButton == NULL && Window()->Lock()) {
 		BView* background = Window()->ChildAt(0);
 		BView* cancel = background->FindView("cancel button");
 
@@ -105,35 +104,37 @@ DirectoryFilePanel::Show()
 void
 DirectoryFilePanel::SelectionChanged()
 {
-	Window()->Lock();
-
 	// Resize button so that the label fits
 	// maximum width is dictated by the window's size limits
 
-	float dummy;
-	float maxWidth;
-	Window()->GetSizeLimits(&maxWidth, &dummy, &dummy, &dummy);
-	maxWidth -= Window()->Bounds().Width() + 8 - fCurrentButton->Frame().right;
+	if (Window()->Lock()) {
+		float dummy;
+		float maxWidth;
+		Window()->GetSizeLimits(&maxWidth, &dummy, &dummy, &dummy);
+		maxWidth -= Window()->Bounds().Width() + 8
+			- fCurrentButton->Frame().right;
 
-	BRect oldBounds = fCurrentButton->Bounds();
+		BRect oldBounds = fCurrentButton->Bounds();
 
-	char* label;
-	entry_ref ref;
-	GetPanelDirectory(&ref);
-	asprintf(&label, B_TRANSLATE("Select '%s'" B_UTF8_ELLIPSIS), ref.name);
-	fCurrentButton->SetLabel(label);
-	free(label);
+		char* label;
+		entry_ref ref;
+		GetPanelDirectory(&ref);
+		asprintf(&label, B_TRANSLATE("Select '%s'" B_UTF8_ELLIPSIS),
+			ref.name);
+		fCurrentButton->SetLabel(label);
+		free(label);
 
-	float width;
-	float height;
-	fCurrentButton->GetPreferredSize(&width, &height);
-	if (width > maxWidth)
-		width = maxWidth;
+		float width;
+		float height;
+		fCurrentButton->GetPreferredSize(&width, &height);
+		if (width > maxWidth)
+			width = maxWidth;
 
-	fCurrentButton->ResizeTo(width, oldBounds.Height());
-	fCurrentButton->MoveBy(oldBounds.Width() - width, 0);
+		fCurrentButton->ResizeTo(width, oldBounds.Height());
+		fCurrentButton->MoveBy(oldBounds.Width() - width, 0);
 
-	Window()->Unlock();
+		Window()->Unlock();
+	}
 
 	BFilePanel::SelectionChanged();
 }